test: remove dataset service update/delete mock tests superseded by testcontainers#34937
Merged
asukaminato0721 merged 1 commit intolanggenius:mainfrom Apr 11, 2026
Conversation
Contributor
Pyrefly DiffNo changes detected. |
dosubot
Bot
added
the
size:XL
asukaminato0721
approved these changes
Apr 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a mock-based unit test module for DatasetService update/delete behavior that is now covered by existing Testcontainers-backed integration tests, aligning with the ongoing move away from patched SQL/mocks (Issue #32454).
Changes:
- Delete
api/tests/unit_tests/services/dataset_service_update_delete.py(mock-heavy unit tests) to avoid duplicate coverage. - Rely on existing Testcontainers integration tests for update/delete and related dataset lifecycle behaviors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api/tests/unit_tests/services/dataset_service_update_delete.py(9 mock-based tests, 818 lines)api/tests/test_containers_integration_tests/services/test_dataset_service_update_dataset.py(13 tests)api/tests/test_containers_integration_tests/services/dataset_service_update_delete.py(9 tests)Part of #32454
Test plan