Support workflow_run_id query param on workflow logs page#34951
Open
ashutoshrana wants to merge 2 commits intolanggenius:mainfrom
Open
Support workflow_run_id query param on workflow logs page#34951ashutoshrana wants to merge 2 commits intolanggenius:mainfrom
ashutoshrana wants to merge 2 commits intolanggenius:mainfrom
Conversation
5 tasks
Author
|
Created a feature issue for this PR per the contribution guidelines: fixes #35375 The issue describes the use case and implementation approach. Happy to address any review feedback — let me know if there's anything to update in the PR itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supports passing
workflow_run_idvia the workflow logs URL for faster lookup.Example:
/app/<appId>/logs?workflow_run_id=<runId>This change:
workflow_run_idworkflow_run_idin sync when the keyword changespagefrom the URL when the keyword changesScope
This PR is intentionally narrow:
workflow_run_idWhy no backend change
The existing workflow logs backend already supports matching workflow run IDs through the current
keywordsearch path, so this PR only adds the missing URL/state wiring on the frontend.Validation
Ran:
pnpm -C web test -- --run app/components/app/workflow-log/__tests__pnpm -C web test -- --run app/components/app/log/__tests__pnpm -C web test -- --run app/components/app/log-annotation/__tests__Notes
This PR supports URL-based initialization of the workflow log search from
workflow_run_id.It does not try to implement full post-mount URL/state synchronization for every possible navigation case. I kept that out of scope to keep the first contribution small and aligned with the issue request.