refactor(api): remove type: ignore and FIXME comments in factories#34978
Open
zmjaction wants to merge 1 commit intolanggenius:mainfrom
Open
refactor(api): remove type: ignore and FIXME comments in factories#34978zmjaction wants to merge 1 commit intolanggenius:mainfrom
zmjaction wants to merge 1 commit intolanggenius:mainfrom
Conversation
Use cast() to assert the correct extension class type instead of silencing the type checker with type: ignore. This aligns with the project's goal of precise type annotations and removes long-standing FIXME comments. - api/core/moderation/factory.py - api/core/external_data_tool/factory.py
dosubot
bot
added
size:XS
Contributor
Pyrefly DiffNo changes detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove FIXME and
type: ignoreinModerationFactoryandExternalDataToolFactory.extension_class()returns a baretype, so mypy doesn't knowvalidate_configexists on the returned class. Usingcast(type[Moderation], ...)andcast(type[ExternalDataTool], ...)fixes it without silencing the checker.
No runtime changes.
Fixes #34977