fix: exclude None fields in MCP Dynamic Client Registration request#35002
Open
samrusani wants to merge 1 commit intolanggenius:mainfrom
Open
fix: exclude None fields in MCP Dynamic Client Registration request#35002samrusani wants to merge 1 commit intolanggenius:mainfrom
samrusani wants to merge 1 commit intolanggenius:mainfrom
Conversation
Strict MCP servers (e.g., GitLab) reject requests containing null values for optional fields. Use model_dump(exclude_none=True) to omit unset optional fields from the registration payload. Closes langgenius#34857 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dosubot
bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
model_dump(exclude_none=True)instead ofmodel_dump()when serializingclient_metadatafor OAuth Dynamic Client Registration. Strict MCP servers (e.g., GitLab) return HTTP 400 when optional fields are sent as JSONnull. One-line change inapi/core/mcp/auth/auth_flow.py.Fixes #34857
Screenshots
N/A — backend-only change.
Checklist
make lintandmake type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsFrom Claude Code