fix: clear stale conversation_id on 404 to prevent infinite retry loop#35003
Open
samrusani wants to merge 1 commit intolanggenius:mainfrom
Open
fix: clear stale conversation_id on 404 to prevent infinite retry loop#35003samrusani wants to merge 1 commit intolanggenius:mainfrom
samrusani wants to merge 1 commit intolanggenius:mainfrom
Conversation
…infinite retry loop When a conversation is deleted server-side, the frontend kept retrying with the stale conversation_id from localStorage, creating an infinite 404 error loop. This fix: 1. Disables TanStack Query retries on 404 in useShareChatList 2. Adds a useEffect in both chat-with-history and embedded-chatbot hooks to clear the stale conversation_id from localStorage when a 404 is detected, resetting the user to a new conversation state Closes langgenius#34731 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dosubot
bot
added
the
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a conversation is deleted server-side, the Web App chatbot entered an infinite 404 error loop because the stale
conversation_idpersisted inlocalStorageand TanStack Query kept retrying.retryfunction touseShareChatListthat skips retries on 404 responses (unrecoverable errors)useEffectin bothchat-with-history/hooks.tsxandembedded-chatbot/hooks.tsxto detect 404 errors and clear the staleconversation_idfromlocalStorage, resetting to a new conversation stateFixes #34731
Screenshots
N/A — logic-only change, no visual changes.
Checklist
make lintandmake type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsFrom Claude Code