Skip to content

refactor: replace bare dict with dict[str, Any] in VDB providers#35110

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
wdeveloper16:refactor/typed-dict-vdb-providers
Apr 14, 2026
Merged

refactor: replace bare dict with dict[str, Any] in VDB providers#35110
crazywoola merged 1 commit intolanggenius:mainfrom
wdeveloper16:refactor/typed-dict-vdb-providers

Conversation

@wdeveloper16
Copy link
Copy Markdown
Contributor

Summary

Tighten bare dict / dict | None annotations across 12 vector database provider packages under api/providers/vdb/:

  • Relyt, OpenSearch, Milvus, Lindorm, Huawei Cloud, Elasticsearch — validate_config.values, create_collection.metadatas/index_params, similarity_search_with_score_by_vector.filter
  • PgVector, TiDB, Tablestore, Upstash, Vastbase, Weaviate — validate_config.values

All VDB config values are provider-specific, so dict[str, Any] is the correct shape. Any is already imported in each file.

No behavior change — types only.

Part of #22651.

Test plan

  • make lint passes
  • make type-check-core passes (1391 files)

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. refactor labels Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Diff

No changes detected.

Copy link
Copy Markdown
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required checks are green and these type annotation tighten-ups look good to merge.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 14, 2026
@crazywoola crazywoola added this pull request to the merge queue Apr 14, 2026
Merged via the queue into langgenius:main with commit 4ee1bd5 Apr 14, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants