refactor: replace bare dict with dict[str, Any] in core provider services and misc modules#35124
Merged
crazywoola merged 1 commit intolanggenius:mainfrom Apr 14, 2026
Conversation
dosubot
Bot
added
size:M
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-04-14 01:53:59.638566467 +0000
+++ /tmp/pyrefly_pr.txt 2026-04-14 01:53:48.914585911 +0000
@@ -118,6 +118,10 @@
--> core/rag/index_processor/processor/qa_index_processor.py:209:16
ERROR No matching overload found for function `core.model_manager.ModelInstance.invoke_llm` called with arguments: (prompt_messages=list[SystemPromptMessage | UserPromptMessage], tools=list[PromptMessageTool], stream=Literal[False], model_parameters=dict[str, float | int]) [no-matching-overload]
--> core/rag/retrieval/router/multi_dataset_function_call_router.py:32:58
+ERROR Returned type `dict[TelemetryCase, CaseRoute]` is not assignable to declared return type `dict[str, Any]` [bad-return]
+ --> core/telemetry/gateway.py:95:16
+ERROR Returned type `dict[TelemetryCase, TraceTaskName]` is not assignable to declared return type `dict[str, Any]` [bad-return]
+ --> core/telemetry/gateway.py:97:16
ERROR Class member `MCPToolProviderController.entity` overrides parent class `ToolProviderController` in an inconsistent manner [bad-override]
--> core/tools/mcp_tool/provider.py:33:14
ERROR Class member `PluginToolProviderController.entity` overrides parent class `BuiltinToolProviderController` in an inconsistent manner [bad-override]
|
…ices and misc modules
wdeveloper16
force-pushed
the
refactor/typed-dict-core-provider-services
branch
from
94c2efe to
65f3a1b
Compare
Contributor
Pyrefly DiffNo changes detected. |
crazywoola
approved these changes
Apr 14, 2026
Member
crazywoola
left a comment
crazywoola
left a comment
There was a problem hiding this comment.
Required checks are green and these type annotation tighten-ups look good to merge.
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
…ices and misc modules (langgenius#35124)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bare
dictwithdict[str, Any]acrosscore/provider_manager.py,core/model_manager.py,core/entities/provider_entities.py,core/external_data_tool/factory.py,core/telemetry/gateway.py,core/prompt/simple_prompt_transform.py,core/rag/embedding/(cached + base),core/rag/datasource/retrieval_service.py,services/app_model_config_service.py,services/auth/api_key_auth_service.py,services/tools/tools_transform_service.py,configs/middleware/vdb/iris_config.py, andextensions/storage/clickzetta_volume/clickzetta_volume_storage.py.Add
from typing import Anywhere missing.Part of #22651.