Skip to content

fix: doc modal hidden by config modal#35157

Merged
iamjoel merged 1 commit intomainfrom
fix/doc-z-index
Apr 14, 2026
Merged

fix: doc modal hidden by config modal#35157
iamjoel merged 1 commit intomainfrom
fix/doc-z-index

Conversation

@iamjoel
Copy link
Copy Markdown
Contributor

@iamjoel iamjoel commented Apr 14, 2026

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@iamjoel iamjoel requested a review from zhsama as a code owner April 14, 2026 08:07
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 14, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Apr 14, 2026
@iamjoel iamjoel changed the title fix: doc hidden by config modal fix: doc modal hidden by config modal Apr 14, 2026
Copy link
Copy Markdown
Contributor

@CodingOnStar CodingOnStar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 14, 2026
@iamjoel iamjoel enabled auto-merge April 14, 2026 08:10
@iamjoel iamjoel added this pull request to the merge queue Apr 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.88%. Comparing base (fbedb60) to head (6e2591a).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #35157   +/-   ##
=======================================
  Coverage   84.88%   84.88%           
=======================================
  Files        4362     4362           
  Lines      196074   196074           
  Branches    37261    37261           
=======================================
  Hits       166440   166440           
  Misses      26583    26583           
  Partials     3051     3051           
Flag Coverage Δ
web 85.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into main with commit 9a47bb2 Apr 14, 2026
35 checks passed
@iamjoel iamjoel deleted the fix/doc-z-index branch April 14, 2026 08:27
HanqingZ pushed a commit to HanqingZ/dify that referenced this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants