Skip to content

ci: Add conditional comment creation for diff#35179

Merged
asukaminato0721 merged 2 commits intomainfrom
quiet-when-no-diff
Apr 17, 2026
Merged

ci: Add conditional comment creation for diff#35179
asukaminato0721 merged 2 commits intomainfrom
quiet-when-no-diff

Conversation

@asukaminato0721
Copy link
Copy Markdown
Contributor

@asukaminato0721 asukaminato0721 commented Apr 14, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

it send comment every time.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

Copilot AI review requested due to automatic review settings April 14, 2026 14:16
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 14, 2026
@asukaminato0721 asukaminato0721 changed the title Add conditional comment creation for diff ci: Add conditional comment creation for diff Apr 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Pyrefly diff comment GitHub Actions workflow to avoid posting a PR comment when the generated diff is empty, reducing comment noise from no-op runs.

Changes:

  • Gate github.rest.issues.createComment(...) behind a diff.trim() check so comments are only created when there is an actual diff.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pyrefly-diff-comment.yml Outdated
@asukaminato0721 asukaminato0721 requested a review from WH-2099 April 17, 2026 09:10
@asukaminato0721 asukaminato0721 added this pull request to the merge queue Apr 17, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 17, 2026
Merged via the queue into main with commit 9ce7464 Apr 17, 2026
29 checks passed
@asukaminato0721 asukaminato0721 deleted the quiet-when-no-diff branch April 17, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants