feat(web): unify create_app tracking and persist external attribution#35241
Merged
CodingOnStar merged 8 commits intomainfrom Apr 15, 2026
Merged
feat(web): unify create_app tracking and persist external attribution#35241CodingOnStar merged 8 commits intomainfrom
CodingOnStar merged 8 commits intomainfrom
Conversation
added 6 commits
April 13, 2026 14:12
…acking utilities - Added functions to extract and clear external attribution parameters from the URL. - Updated AppInitializer to utilize new attribution functions. - Modified AmplitudeProvider to conditionally initialize based on the new isAmplitudeEnabled flag. - Enhanced tests to verify the correct behavior of external attribution handling and URL parameter management.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35241 +/- ##
==========================================
+ Coverage 84.85% 84.87% +0.02%
==========================================
Files 4360 4363 +3
Lines 196669 196854 +185
Branches 37276 37323 +47
==========================================
+ Hits 166883 167088 +205
+ Misses 26706 26686 -20
Partials 3080 3080
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ng utilities - Introduced a new test suite for AppInitializer to validate external attribution handling. - Updated create-app-tracking functions to handle cases when the window is unavailable. - Added tests to ensure proper behavior when dealing with malformed UTM cookies and absence of attribution parameters.
iamjoel
reviewed
Apr 15, 2026
iamjoel
requested changes
Apr 15, 2026
iamjoel
approved these changes
Apr 15, 2026
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
…langgenius#35241) Co-authored-by: CodingOnStar <hanxujiang@dify.com>
asukaminato0721
pushed a commit
to asukaminato0721/dify
that referenced
this pull request
Apr 24, 2026
…langgenius#35241) Co-authored-by: CodingOnStar <hanxujiang@dify.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refines app creation tracking and consolidates all create-related reporting into a single
create_appevent.sessionStorageto avoid losing it across registration/login and page switchesutm_source/utm_campaign/slugfrom the URL after attribution is capturedcreate_appreporting to avoid duplicate external attributionChecklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods