fix(web): set app card dropdown menu to non-modal#35302
Merged
Conversation
The operations dropdown on AppCard used the default modal behavior,
which traps focus and blocks outside interaction. Set modal={false}
so the menu behaves as a lightweight popup suitable for card lists.
Made-with: Cursor
dosubot
Bot
added
the
size:XS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35302 +/- ##
==========================================
- Coverage 85.07% 85.07% -0.01%
==========================================
Files 4396 4396
Lines 201630 201630
Branches 38301 38301
==========================================
- Hits 171540 171534 -6
- Misses 26987 26993 +6
Partials 3103 3103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
asukaminato0721
pushed a commit
to asukaminato0721/dify
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modal={false}on the app card operationsDropdownMenuso it no longer traps focus or blocks interaction with elements outside the menu. This is the expected behavior for a lightweight context menu on card lists.modalprop and added a test assertingmodal={false}.From Cursor
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsMade with Cursor