refactor(web): replace portal component with DropdownMenu in various components by CodingOnStar · Pull Request #35319 · langgenius/dify

CodingOnStar · 2026-04-16T09:23:50Z

Important

Make sure you have read our contribution guidelines
Ensure there is an associated issue and you have been assigned to it
Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Updated DebugItem, MobileOperationDropdown, and Operation components to utilize DropdownMenu for improved dropdown functionality.
Removed deprecated Dropdown component references and adjusted related tests accordingly.
Enhanced user interactions and accessibility across dropdown menus.

Checklist

This change requires a documentation update, included: Dify Document
I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
I've updated the documentation accordingly.
I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

…s components - Updated PublishWithMultipleModel, AppSidebarDropdown, DatasetSidebarDropdown, and others to use DropdownMenu for dropdown functionality. - Adjusted related tests to reflect the new DropdownMenu structure. - Enhanced the user interface by improving dropdown interactions and accessibility.

…s components - Updated DebugItem, MobileOperationDropdown, and Operation components to utilize DropdownMenu for improved dropdown functionality. - Removed deprecated Dropdown component references and adjusted related tests accordingly. - Enhanced user interactions and accessibility across dropdown menus.

…and dropdown migrations Toast and dropdown have been fully migrated — legacy directories deleted, zero remaining imports, ESLint restrictions removed. Remove the outdated "Toast migration strategy" section and split the Scope list into "still in progress" vs "completed". Made-with: Cursor

…bility - Modified test cases in various components to utilize async methods like and for better handling of asynchronous rendering. - Ensured that elements are properly awaited before assertions, enhancing test stability and accuracy.

codecov · 2026-04-16T11:56:46Z

Codecov Report

❌ Patch coverage is 97.56098% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.16%. Comparing base (af8ffa0) to head (26a6c6e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...b/app/components/workflow/operator/zoom-in-out.tsx	91.42%	3 Missing ⚠️
...ion/debug/debug-with-multiple-model/debug-item.tsx	95.83%	1 Missing ⚠️
...ow/nodes/_base/components/panel-operator/index.tsx	88.88%	1 Missing ⚠️
...s/workflow/note-node/note-editor/toolbar/index.tsx	50.00%	1 Missing ⚠️
.../app/components/workflow/operator/more-actions.tsx	92.30%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #35319      +/-   ##
==========================================
+ Coverage   85.08%   85.16%   +0.07%     
==========================================
  Files        4397     4396       -1     
  Lines      201757   201732      -25     
  Branches    38324    38320       -4     
==========================================
+ Hits       171664   171796     +132     
+ Misses      26987    26830     -157     
  Partials     3106     3106

Flag	Coverage Δ
web	`86.45% <97.56%> (+0.17%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…tor specs

…35347) Co-authored-by: CodingOnStar <hanxujiang@dify.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) Co-authored-by: ai-hpc <ai-hpc@users.noreply.github.com>

…35334)

…#35298) Co-authored-by: ai-hpc <ai-hpc@users.noreply.github.com> Co-authored-by: Asuka Minato <i@asukaminato.eu.org> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

github-actions · 2026-04-17T05:45:02Z

Pyrefly Type Coverage

Metric	Base	PR	Delta
Type coverage	38.85%	38.85%	0.00%
Strict coverage	35.94%	35.94%	0.00%
Typed symbols	18,447	18,447	0
Untyped symbols	31,387	31,387	0
Modules	2542	2542	0

github-actions · 2026-04-17T05:45:16Z

Pyrefly Diff

No changes detected.

CodingOnStar added 2 commits April 16, 2026 15:30

CodingOnStar requested a review from lyzno1 April 16, 2026 09:23

github-actions bot added the web This relates to changes on the web. label Apr 16, 2026

CodingOnStar changed the title ~~refactor(web): replace Dropdown component with DropdownMenu in various components~~ refactor(web): replace portal component with DropdownMenu in various components Apr 16, 2026

autofix-ci bot and others added 2 commits April 16, 2026 09:26

[autofix.ci] apply automated fixes

9356b30

lyzno1 force-pushed the feat/dropdown-migaration branch from 9732ec1 to 389901d Compare April 16, 2026 10:22

CodingOnStar and others added 6 commits April 17, 2026 10:57

Merge remote-tracking branch 'origin/main' into feat/dropdown-migaration

b855f45

[autofix.ci] apply automated fixes

d46ba70

merge

2ae644d

test: add DropdownMenuLabel mock to test-run-menu and operation-selec…

10638d8

…tor specs

fix: stabilize note toolbar interactions and polish plugin task overlays

3d18213

[autofix.ci] apply automated fixes

c6f81b1

CodingOnStar marked this pull request as ready for review April 17, 2026 05:39

CodingOnStar requested review from JzoNgKVO, WTW0313, Yessenia-d, Yeuoly, crazywoola, hyoban, iamjoel, laipz8200, zhsama and zxhlyh as code owners April 17, 2026 05:39

dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. javascript Pull requests that update javascript code refactor labels Apr 17, 2026

CodingOnStar and others added 11 commits April 17, 2026 13:43

feat(web): add tracking for app preview events in AppCard component (#…

056ac35

…35347) Co-authored-by: CodingOnStar <hanxujiang@dify.com>

chore(deps): bump authlib from 1.6.9 to 1.6.11 in /api (#35341)

79d4ed2

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump mako from 1.3.10 to 1.3.11 in /api (#35340)

723cedc

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump pypdf from 6.10.1 to 6.10.2 in /api (#35339)

029d19a

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(api): migrate event handlers to use Session(db.engine) (#35234)

5a63ca8

refactor(api): migrate console mcp-server responses to BaseModel (#35219

07b115e

) Co-authored-by: ai-hpc <ai-hpc@users.noreply.github.com>

docs(web): add Storybook stories for overlay and select primitives (#…

835390e

…35334)

refactor(api): migrate dataset document response schemas to BaseModel (…

ddc694a

…#35298) Co-authored-by: ai-hpc <ai-hpc@users.noreply.github.com> Co-authored-by: Asuka Minato <i@asukaminato.eu.org> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

fix(web): stop Splash after useUserProfile errors (#35326)

f887e95

refactor: use sessionmaker in api_tools_manage_service.py (#34892)

f50747f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

chore: remove eslint suppressions file as it is no longer needed

c18fad4

CodingOnStar requested review from JohnJyong and QuantumGhost as code owners April 17, 2026 05:43

github-actions bot added the needs-revision label Apr 17, 2026

Merge branch 'main' into feat/dropdown-migaration

26a6c6e

lyzno1 approved these changes Apr 17, 2026

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 17, 2026

CodingOnStar enabled auto-merge April 17, 2026 05:49

CodingOnStar added this pull request to the merge queue Apr 17, 2026

Merged via the queue into main with commit b6c7581 Apr 17, 2026
33 checks passed

CodingOnStar deleted the feat/dropdown-migaration branch April 17, 2026 06:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(web): replace portal component with DropdownMenu in various components#35319

refactor(web): replace portal component with DropdownMenu in various components#35319
CodingOnStar merged 23 commits intomainfrom
feat/dropdown-migaration

CodingOnStar commented Apr 16, 2026

Uh oh!

codecov bot commented Apr 16, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 17, 2026

Uh oh!

github-actions bot commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

CodingOnStar commented Apr 16, 2026

Summary

Checklist

Uh oh!

codecov bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Apr 17, 2026

Pyrefly Type Coverage

Uh oh!

github-actions bot commented Apr 17, 2026

Pyrefly Diff

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Apr 16, 2026 •

edited

Loading