fix: splash keeps rendering when useUserProfile fails#35335
Closed
Protocol-zero-0 wants to merge 1 commit into
Closed
fix: splash keeps rendering when useUserProfile fails#35335Protocol-zero-0 wants to merge 1 commit into
Protocol-zero-0 wants to merge 1 commit into
Conversation
dosubot
Bot
added
the
size:XS
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an indefinite splash/loading overlay when the useUserProfile() query errors by ensuring the Splash component does not keep rendering solely due to missing data.profile in an error state.
Changes:
- Destructure
isErrorfromuseUserProfile()inSplash. - Update the splash render condition to suppress the loading overlay when the profile query is in an error state.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
+10
| const { isPending, data, isError } = useUserProfile() | ||
|
|
||
| if (isPending || !data?.profile) { | ||
| if ((isPending || !data?.profile) && !isError) { |
There was a problem hiding this comment.
Consider adding a small unit test for Splash covering the error state (e.g., mock useUserProfile() to return { isPending: false, isError: true, data: undefined } and assert the loading overlay is not rendered). This regression is subtle and currently isn’t exercised by tests.
Member
|
Duplicated #35326 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35324.
The
Splashcomponent was previously rendering the loading state wheneverisPending || !data?.profilewas true. However, if theuseUserProfilequery failed,datawould remain undefined, causing the splash screen to stay visible indefinitely.This PR adds a check for
isErrorto ensure the splash screen is dismissed if the profile query fails, allowing the normal error or redirect flow to proceed.