Skip to content

fix(web): stabilize workflow node panel operator dropdown trigger#35352

Merged
CodingOnStar merged 25 commits intomainfrom
feat/dropdown-migaration
Apr 17, 2026
Merged

fix(web): stabilize workflow node panel operator dropdown trigger#35352
CodingOnStar merged 25 commits intomainfrom
feat/dropdown-migaration

Conversation

@CodingOnStar
Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix(web): stabilize workflow node panel operator dropdown trigger

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

CodingOnStar and others added 23 commits April 16, 2026 15:30
…s components

- Updated PublishWithMultipleModel, AppSidebarDropdown, DatasetSidebarDropdown, and others to use DropdownMenu for dropdown functionality.
- Adjusted related tests to reflect the new DropdownMenu structure.
- Enhanced the user interface by improving dropdown interactions and accessibility.
…s components

- Updated DebugItem, MobileOperationDropdown, and Operation components to utilize DropdownMenu for improved dropdown functionality.
- Removed deprecated Dropdown component references and adjusted related tests accordingly.
- Enhanced user interactions and accessibility across dropdown menus.
…and dropdown migrations

Toast and dropdown have been fully migrated — legacy directories deleted,
zero remaining imports, ESLint restrictions removed. Remove the outdated
"Toast migration strategy" section and split the Scope list into
"still in progress" vs "completed".

Made-with: Cursor
…bility

- Modified test cases in various components to utilize async methods like  and  for better handling of asynchronous rendering.
- Ensured that elements are properly awaited before assertions, enhancing test stability and accuracy.
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Co-authored-by: ai-hpc <ai-hpc@users.noreply.github.com>
…#35298)

Co-authored-by: ai-hpc <ai-hpc@users.noreply.github.com>
Co-authored-by: Asuka Minato <i@asukaminato.eu.org>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@CodingOnStar CodingOnStar requested a review from lyzno1 April 17, 2026 07:04
@github-actions github-actions Bot added web This relates to changes on the web. needs-revision labels Apr 17, 2026
@CodingOnStar CodingOnStar marked this pull request as ready for review April 17, 2026 07:05
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 17, 2026
lyzno1
lyzno1 previously approved these changes Apr 17, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 17, 2026
@CodingOnStar CodingOnStar enabled auto-merge April 17, 2026 07:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.15%. Comparing base (de15e5b) to head (88161cd).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...s/workflow/nodes/_base/components/node-control.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35352      +/-   ##
==========================================
- Coverage   85.15%   85.15%   -0.01%     
==========================================
  Files        4396     4396              
  Lines      201732   201734       +2     
  Branches    38320    38320              
==========================================
+ Hits       171790   171791       +1     
- Misses      26835    26836       +1     
  Partials     3107     3107              
Flag Coverage Δ
web 86.44% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodingOnStar CodingOnStar added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit eaddd4a Apr 17, 2026
38 of 39 checks passed
@CodingOnStar CodingOnStar deleted the feat/dropdown-migaration branch April 17, 2026 07:37
HanqingZ pushed a commit to HanqingZ/dify that referenced this pull request Apr 23, 2026
…nggenius#35352)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: CodingOnStar <hanxujiang@dify.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: yyh <yuanyouhuilyz@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jerryzai <jerryzh8710@protonmail.com>
Co-authored-by: NVIDIAN <speedy.hpc@hotmail.com>
Co-authored-by: ai-hpc <ai-hpc@users.noreply.github.com>
Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com>
Co-authored-by: Asuka Minato <i@asukaminato.eu.org>
Co-authored-by: Junghwan <70629228+shaun0927@users.noreply.github.com>
Co-authored-by: HeYinKazune <70251095+HeYin-OS@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
asukaminato0721 added a commit to asukaminato0721/dify that referenced this pull request Apr 24, 2026
…nggenius#35352)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: CodingOnStar <hanxujiang@dify.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: yyh <yuanyouhuilyz@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jerryzai <jerryzh8710@protonmail.com>
Co-authored-by: NVIDIAN <speedy.hpc@hotmail.com>
Co-authored-by: ai-hpc <ai-hpc@users.noreply.github.com>
Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com>
Co-authored-by: Asuka Minato <i@asukaminato.eu.org>
Co-authored-by: Junghwan <70629228+shaun0927@users.noreply.github.com>
Co-authored-by: HeYinKazune <70251095+HeYin-OS@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer needs-revision size:M This PR changes 30-99 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants