feat(human-input): expose selected action value#35451
Merged
Blackoutta merged 1 commit intoMay 11, 2026
Merged
Conversation
This was referenced Apr 21, 2026
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-05-10 10:25:00.471183315 +0000
+++ /tmp/pyrefly_pr.txt 2026-05-10 10:24:48.795055936 +0000
@@ -6210,11 +6210,11 @@
ERROR `Literal['2']` is not assignable to TypedDict key `limit` with type `int` [bad-typed-dict-key]
--> tests/unit_tests/services/test_workflow_run_service.py:132:103
ERROR Missing required key `id` for TypedDict `NodeConfigDict` [bad-typed-dict-key]
- --> tests/unit_tests/services/test_workflow_service.py:2747:71
+ --> tests/unit_tests/services/test_workflow_service.py:2755:71
ERROR Missing required key `data` for TypedDict `NodeConfigDict` [bad-typed-dict-key]
- --> tests/unit_tests/services/test_workflow_service.py:2747:71
+ --> tests/unit_tests/services/test_workflow_service.py:2755:71
ERROR Argument `dict[str, str | dict[str, str]]` is not assignable to parameter `node_config` with type `NodeConfigDict` in function `services.workflow_service.WorkflowService._build_human_input_node` [bad-argument-type]
- --> tests/unit_tests/services/test_workflow_service.py:2833:65
+ --> tests/unit_tests/services/test_workflow_service.py:2841:65
ERROR Argument `Literal['api_key']` is not assignable to parameter `credential_type` with type `CredentialType` in function `services.tools.builtin_tools_manage_service.BuiltinToolManageService.list_builtin_provider_credentials_schema` [bad-argument-type]
--> tests/unit_tests/services/tools/test_builtin_tools_manage_service.py:91:89
ERROR Object of class `Mapping` has no attribute `startswith` [missing-attribute]
|
Contributor
Author
|
Release-order note for reviewers: this PR depends on the companion Graphon changes in langgenius/graphon#78 / langgenius/graphon#77. Those Graphon changes need to be merged first, and a Graphon release containing them needs to be published first. Only after Dify can consume that released Graphon version should this PR be merged and included in a Dify release. In short: merge/release Graphon first, then merge/release this Dify PR. |
d3e9508 to
897ae04
Compare
Contributor
Pyrefly Type Coverage
|
QuantumGhost
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Dify-side companion for langgenius/dify#34597.
This PR exposes the selected Human Input action value in preview/editor flows and updates the Human Input UI so the right-hand field is treated as the downstream action value.
Changes
__action_valueto Human Input preview submission outputs__action_valuein Human Input output variable metadataAction ValueCloses #34597.
Dependency
This PR depends on the companion Graphon work:
Verification