refactor: migrate from PortalToFollowElem to Popover component across various components#35454
Merged
CodingOnStar merged 17 commits intomainfrom Apr 21, 2026
Merged
refactor: migrate from PortalToFollowElem to Popover component across various components#35454CodingOnStar merged 17 commits intomainfrom
CodingOnStar merged 17 commits intomainfrom
Conversation
…oss various modules
…ponents in model provider and plugin detail panels
…ves and update deprecation message in constants
…cross various components This commit updates multiple components to replace the PortalToFollowElem with the new Popover component, enhancing the UI consistency and functionality. The changes include adjustments in the trigger and content handling for the Popover, ensuring proper event management and styling. Additionally, tests have been updated to reflect these changes.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #35454 +/- ##
==========================================
+ Coverage 85.51% 85.54% +0.02%
==========================================
Files 4437 4438 +1
Lines 207128 207214 +86
Branches 38589 38623 +34
==========================================
+ Hits 177120 177253 +133
+ Misses 26897 26850 -47
Partials 3111 3111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 3 commits
April 21, 2026 15:05
…component in tests This commit finalizes the transition from the PortalToFollowElem to the Popover component across various test files. The updates include the implementation of Popover's context and trigger handling, ensuring consistent behavior in the UI. All relevant tests have been adjusted to reflect these changes, enhancing the overall test coverage and reliability.
…der prop This commit modifies the PopoverTrigger component in multiple test files to accept React.ReactNode instead of React.ReactElement for the render prop. The implementation has been simplified to enhance readability and maintainability, ensuring consistent behavior across tests.
…ents This commit introduces new test files for the AgentStrategySelector and SearchInput components. The tests cover various functionalities, including user interactions and state management, ensuring robust validation of component behavior. Mocks for dependencies are implemented to isolate tests and enhance reliability.
lyzno1
approved these changes
Apr 21, 2026
HanqingZ
pushed a commit
to HanqingZ/dify
that referenced
this pull request
Apr 23, 2026
… various components (langgenius#35454) Co-authored-by: CodingOnStar <hanxujiang@dify.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
asukaminato0721
pushed a commit
to asukaminato0721/dify
that referenced
this pull request
Apr 24, 2026
… various components (langgenius#35454) Co-authored-by: CodingOnStar <hanxujiang@dify.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
This commit updates multiple components to replace the PortalToFollowElem with the new Popover component, enhancing the UI consistency and functionality. The changes include adjustments in the trigger and content handling for the Popover, ensuring proper event management and styling. Additionally, tests have been updated to reflect these changes.
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods