Skip to content

feat: support slash variable filtering in prompt editor#35460

Merged
iamjoel merged 1 commit intomainfrom
feat/support-search-var-after-splash-in-editor-prompt
Apr 21, 2026
Merged

feat: support slash variable filtering in prompt editor#35460
iamjoel merged 1 commit intomainfrom
feat/support-search-var-after-splash-in-editor-prompt

Conversation

@iamjoel
Copy link
Copy Markdown
Contributor

@iamjoel iamjoel commented Apr 21, 2026

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 21, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Apr 21, 2026
@dosubot dosubot Bot added the 💪 enhancement New feature or request label Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 74.46809% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.51%. Comparing base (da00de6) to head (493d521).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../components/variable/var-reference-vars.helpers.ts 62.06% 11 Missing ⚠️
...s/_base/components/variable/var-reference-vars.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35460      +/-   ##
==========================================
+ Coverage   85.50%   85.51%   +0.01%     
==========================================
  Files        4434     4437       +3     
  Lines      207009   207143     +134     
  Branches    38538    38604      +66     
==========================================
+ Hits       176996   177133     +137     
+ Misses      26904    26901       -3     
  Partials     3109     3109              
Flag Coverage Δ
dify-ui 93.01% <ø> (+0.15%) ⬆️
web 86.36% <74.46%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@CodingOnStar CodingOnStar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2026
@iamjoel iamjoel enabled auto-merge April 21, 2026 07:55
@iamjoel iamjoel added this pull request to the merge queue Apr 21, 2026
Merged via the queue into main with commit 48d23cd Apr 21, 2026
32 of 33 checks passed
@iamjoel iamjoel deleted the feat/support-search-var-after-splash-in-editor-prompt branch April 21, 2026 08:06
HanqingZ pushed a commit to HanqingZ/dify that referenced this pull request Apr 23, 2026
asukaminato0721 pushed a commit to asukaminato0721/dify that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants