Skip to content

test(auth): add sign-in smoke test and core validation #35501

Merged
lyzno1 merged 2 commits intomainfrom
test/auth-sign-in-smoke
Apr 23, 2026
Merged

test(auth): add sign-in smoke test and core validation #35501
lyzno1 merged 2 commits intomainfrom
test/auth-sign-in-smoke

Conversation

@Jingyi-Dify
Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

What

  • Add e2e/features/auth/sign-in.feature with a happy-path sign-in scenario tagged @smoke @core @unauthenticated
  • Add e2e/features/step-definitions/auth/sign-in.steps.ts with three step definitions: open sign-in page, submit credentials, assert landing on apps console
  • Add @core tag to create-app.feature and sign-out.feature; add @core @mode-matrix to create-chatbot-app.feature and create-workflow-app.feature

Why

The existing E2E suite covered sign-out and unauthenticated redirect but had no explicit sign-in scenario. Every authenticated scenario implicitly depends on sign-in working, but it was never directly
tested. The tag additions align existing scenarios with the planned @smoke / @core / @mode-matrix suite structure for CI-level targeted runs.

Effect

  • --tags @smoke now includes a sign-in scenario that runs on every PR
  • Step definitions reuse adminCredentials from fixtures/auth.ts and existing locator patterns — no new infrastructure required
  • Pre-existing lint errors in unrelated e2e files are not introduced or worsened by this change

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 23, 2026
@Jingyi-Dify Jingyi-Dify requested review from iamjoel and lyzno1 April 23, 2026 01:25
@lyzno1 lyzno1 requested a review from Copilot April 23, 2026 04:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated happy-path sign-in E2E smoke scenario and aligns existing E2E scenarios with the @core / @mode-matrix tagging scheme for targeted CI runs.

Changes:

  • Add a new @smoke @core @unauthenticated sign-in feature plus step definitions that perform login and assert landing on /apps.
  • Tag existing app-creation and sign-out features with @core (and @mode-matrix where applicable) to support suite partitioning.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
e2e/features/step-definitions/auth/sign-in.steps.ts Adds Playwright+Cucumber steps to navigate to /signin, submit admin credentials, and assert URL is /apps.
e2e/features/auth/sign-in.feature Introduces the new sign-in smoke scenario tagged for CI selection.
e2e/features/auth/sign-out.feature Adds @core tag to include sign-out coverage in the core suite.
e2e/features/apps/create-app.feature Adds @core tag for core suite coverage.
e2e/features/apps/create-chatbot-app.feature Adds @core @mode-matrix tags for matrixed runs.
e2e/features/apps/create-workflow-app.feature Adds @core @mode-matrix tags for matrixed runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread e2e/features/step-definitions/auth/sign-in.steps.ts
@lyzno1
Copy link
Copy Markdown
Member

lyzno1 commented Apr 23, 2026

Related #34278

@lyzno1 lyzno1 enabled auto-merge April 23, 2026 04:52
@lyzno1 lyzno1 added this pull request to the merge queue Apr 23, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 23, 2026
Merged via the queue into main with commit b59ecea Apr 23, 2026
30 checks passed
@lyzno1 lyzno1 deleted the test/auth-sign-in-smoke branch April 23, 2026 04:59
asukaminato0721 pushed a commit to asukaminato0721/dify that referenced this pull request Apr 24, 2026
)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants