test(auth): add sign-in smoke test and core validation #35501
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated happy-path sign-in E2E smoke scenario and aligns existing E2E scenarios with the @core / @mode-matrix tagging scheme for targeted CI runs.
Changes:
- Add a new
@smoke @core @unauthenticatedsign-in feature plus step definitions that perform login and assert landing on/apps. - Tag existing app-creation and sign-out features with
@core(and@mode-matrixwhere applicable) to support suite partitioning.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| e2e/features/step-definitions/auth/sign-in.steps.ts | Adds Playwright+Cucumber steps to navigate to /signin, submit admin credentials, and assert URL is /apps. |
| e2e/features/auth/sign-in.feature | Introduces the new sign-in smoke scenario tagged for CI selection. |
| e2e/features/auth/sign-out.feature | Adds @core tag to include sign-out coverage in the core suite. |
| e2e/features/apps/create-app.feature | Adds @core tag for core suite coverage. |
| e2e/features/apps/create-chatbot-app.feature | Adds @core @mode-matrix tags for matrixed runs. |
| e2e/features/apps/create-workflow-app.feature | Adds @core @mode-matrix tags for matrixed runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Related #34278 |
lyzno1
approved these changes
Apr 23, 2026
asukaminato0721
pushed a commit
to asukaminato0721/dify
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
What
e2e/features/auth/sign-in.featurewith a happy-path sign-in scenario tagged@smoke @core @unauthenticatede2e/features/step-definitions/auth/sign-in.steps.tswith three step definitions: open sign-in page, submit credentials, assert landing on apps console@coretag tocreate-app.featureandsign-out.feature; add@core @mode-matrixtocreate-chatbot-app.featureandcreate-workflow-app.featureWhy
The existing E2E suite covered sign-out and unauthenticated redirect but had no explicit sign-in scenario. Every authenticated scenario implicitly depends on sign-in working, but it was never directly
tested. The tag additions align existing scenarios with the planned @smoke / @core / @mode-matrix suite structure for CI-level targeted runs.
Effect
--tags @smokenow includes a sign-in scenario that runs on every PRadminCredentialsfromfixtures/auth.tsand existing locator patterns — no new infrastructure requiredScreenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods