fix: prioritize URL conversation_id over localStorage in embedded chatbot#35519
Merged
crazywoola merged 2 commits intolanggenius:mainfrom Apr 28, 2026
Merged
Conversation
…tbot When embed.js creates an iframe with a conversation_id parameter, the embedded chatbot ignored it because localStorage's conversationIdInfo always took higher priority. This caused new conversations to fail to start when a previous conversation was already stored in localStorage. Swap the priority order in currentConversationId so URL-provided conversation_id takes precedence, falling back to localStorage only when no URL param is present. fixes langgenius#35489 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
treekimm
requested review from
CodingOnStar,
hyoban,
iamjoel and
zxhlyh
as code owners
dosubot
Bot
added
the
size:XS
github-actions
Bot
added
web
dosubot
Bot
added
the
size:XS
crazywoola
approved these changes
Apr 28, 2026
fatelei
pushed a commit
that referenced
this pull request
Apr 29, 2026
…tbot (#35519) Co-authored-by: KimNamWoo <treekim@KimNamWoos-Mac-mini.local> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
currentConversationIdpriority in embedded chatbot hook so URL-providedconversation_idtakes precedence over localStorageconversation_idparameter, it was ignored becauseconversationIdInfofrom localStorage always wonfixes #35489
Related Issues
Test plan
pnpm test run app/components/base/chat/embedded-chatbot/__tests__/hooks.spec.tsx— 35 tests passedembed.min.jswith aconversation_idparam, verify it loads the correct conversationconversation_id, localStorage fallback still works as beforeconversation_idvia embed.js reloads the correct conversation🤖 Generated with Claude Code