Merged
Conversation
wylswz
requested review from
GareArc,
GarfieldDai and
QuantumGhost
as code owners
dosubot
Bot
added
the
size:M
fatelei
approved these changes
Apr 24, 2026
GareArc
reviewed
Apr 24, 2026
| self.credentials_cache = {} | ||
|
|
||
| def fetch(self, provider_name: str, model_name: str) -> dict[str, Any]: | ||
| if (provider_name, model_name) in self.credentials_cache: |
Contributor
There was a problem hiding this comment.
Seems like this cache overlaps with ModelManager._credentials_cache enabled at L107. Both ultimately call provider_configuration.get_current_credentials for the same (provider, LLM, model).
asukaminato0721
pushed a commit
to asukaminato0721/dify
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
see #35528
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods