Skip to content

chore(dify-ui): update tooltip and infotip migration#35543

Merged
lyzno1 merged 4 commits intomainfrom
codex/tooltip-migration
Apr 24, 2026
Merged

chore(dify-ui): update tooltip and infotip migration#35543
lyzno1 merged 4 commits intomainfrom
codex/tooltip-migration

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented Apr 24, 2026

Summary

  • Migrated the workflow batch from the legacy overlay tooltip to the new compound tooltip API where the trigger is a short label, action, or status hint.
  • Switched info-glyph explanations to Infotip and aligned its default popup radius with the tooltip surface.
  • Removed the obsolete lint command block from web/docs/overlay-migration.md.

Testing

  • Not run (not requested)
  • Reviewed the pending frontend diff for semantic tooltip/infotip usage, accessibility attributes, and regression risk in the touched workflow and billing surfaces.

@lyzno1 lyzno1 requested review from iamjoel and zxhlyh as code owners April 24, 2026 05:50
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Apr 24, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Apr 24, 2026
@lyzno1 lyzno1 force-pushed the codex/tooltip-migration branch from c630951 to 59fb441 Compare April 24, 2026 05:51
@lyzno1 lyzno1 changed the title Update tooltip and infotip migration chore(dify-ui): update tooltip and infotip migration Apr 24, 2026
@lyzno1 lyzno1 enabled auto-merge April 24, 2026 05:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 75.86207% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.57%. Comparing base (48e13f6) to head (b006c59).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...omponents/json-schema-config-modal/code-editor.tsx 0.00% 5 Missing ⚠️
.../nodes/_base/components/form-input-type-switch.tsx 70.00% 3 Missing ⚠️
...a-config-modal/visual-editor/edit-card/actions.tsx 0.00% 3 Missing ⚠️
...ents/workflow/nodes/_base/components/help-link.tsx 0.00% 2 Missing ⚠️
...ents/workflow/nodes/agent/components/model-bar.tsx 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35543      +/-   ##
==========================================
- Coverage   85.57%   85.57%   -0.01%     
==========================================
  Files        4440     4440              
  Lines      207877   207891      +14     
  Branches    38845    38846       +1     
==========================================
+ Hits       177893   177898       +5     
- Misses      26861    26870       +9     
  Partials     3123     3123              
Flag Coverage Δ
dify-ui 93.01% <ø> (ø)
web 86.49% <75.86%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 added this pull request to the merge queue Apr 24, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 24, 2026
Merged via the queue into main with commit ec450eb Apr 24, 2026
32 of 33 checks passed
@lyzno1 lyzno1 deleted the codex/tooltip-migration branch April 24, 2026 06:46
asukaminato0721 pushed a commit to asukaminato0721/dify that referenced this pull request Apr 24, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants