feat: refactor modals to use Dialog component and add tests for ApiKeyModal and ProviderConfigModal#35550
Merged
CodingOnStar merged 3 commits intomainfrom Apr 24, 2026
Merged
feat: refactor modals to use Dialog component and add tests for ApiKeyModal and ProviderConfigModal#35550CodingOnStar merged 3 commits intomainfrom
CodingOnStar merged 3 commits intomainfrom
Conversation
…yModal and ProviderConfigModal - Replaced Modal with Dialog in ApiKeyModal and ProviderConfigModal for improved UI consistency. - Updated handling of modal open/close states. - Added comprehensive tests for ProviderConfigModal, covering various tracing provider configurations. - Enhanced ApiKeyModal tests to validate form schema handling and submission logic.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35550 +/- ##
==========================================
- Coverage 85.59% 85.59% -0.01%
==========================================
Files 4444 4452 +8
Lines 208236 208636 +400
Branches 38896 39044 +148
==========================================
+ Hits 178238 178577 +339
- Misses 26853 26914 +61
Partials 3145 3145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ac1496e to
0b16c8d
Compare
…Modal and ProviderConfigModal - Updated state management for modal visibility in ApiKeyModal and ProviderConfigModal to use controlled components. - Refactored modal open/close logic for better clarity and consistency. - Improved tests for ApiKeyModal to ensure proper handling of open state and interactions. - Enhanced ProviderConfigModal tests to cover additional scenarios and edge cases.
0b16c8d to
c41e9a6
Compare
lyzno1
approved these changes
Apr 24, 2026
Contributor
Author
asukaminato0721
pushed a commit
to asukaminato0721/dify
that referenced
this pull request
Apr 24, 2026
…yModal and ProviderConfigModal (langgenius#35550) Co-authored-by: CodingOnStar <hanxujiang@dify.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsFixes #35456
Fixes #35548