fix: enhance file uploader with billing support and update translations#35583
Merged
fix: enhance file uploader with billing support and update translations#35583
Conversation
Update both UploadDropzone test suites to match the recent source changes that switched the icon to a Tailwind icon-font span and made the tip text branch on `enableBilling` from ProviderContext. - Mock `useProviderContextSelector` so tests can toggle billing state - Replace stale `<svg>` icon assertion with `.i-ri-upload-cloud-2-line` - Add cases for `tip` vs `tipWithTotalLimit` and verify only the billing-enabled branch passes `totalCount` into the translation Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35583 +/- ##
==========================================
- Coverage 85.64% 85.64% -0.01%
==========================================
Files 4454 4454
Lines 208892 208898 +6
Branches 39061 39065 +4
==========================================
+ Hits 178902 178906 +4
- Misses 26844 26847 +3
+ Partials 3146 3145 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mirror the en-US split (`tip` without `totalCount`, new `tipWithTotalLimit` with `totalCount`) across all 22 supported locales. Existing translations are preserved as `tipWithTotalLimit`; the shortened `tip` drops only the trailing "max total N files" clause so no machine-translated text is introduced. Made-with: Cursor
iamjoel
approved these changes
Apr 27, 2026
fatelei
pushed a commit
that referenced
this pull request
Apr 29, 2026
…ns (#35583) Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Hide
Max total {{limit}} filesin CE and EE.Fixes #35584
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods