Skip to content

fix: show full checklist message tooltip instead of truncated#35613

Merged
lyzno1 merged 2 commits intolanggenius:mainfrom
hjlarry:p412
Apr 28, 2026
Merged

fix: show full checklist message tooltip instead of truncated#35613
lyzno1 merged 2 commits intolanggenius:mainfrom
hjlarry:p412

Conversation

@hjlarry
Copy link
Copy Markdown
Contributor

@hjlarry hjlarry commented Apr 28, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #35612

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@hjlarry hjlarry requested review from iamjoel and zxhlyh as code owners April 28, 2026 01:50
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 28, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Apr 28, 2026
@lyzno1
Copy link
Copy Markdown
Member

lyzno1 commented Apr 28, 2026

I don’t think tooltip is the right semantic fit here. These checklist messages are primary validation content in an already-expanded details popover, not supplementary hints.

Instead of adding hover-only disclosure logic, I’d suggest rendering the full message directly and allowing it to wrap. We can keep the action aligned with the first line by switching the row alignment to items-start and adding top padding to the right action.

Something like:

<div className="group/item flex items-start gap-2 rounded-lg px-1 ...">
  <ItemIndicator />
  <span className="min-w-0 grow py-1 text-xs leading-4 text-text-warning">
    {sub.message}
  </span>
  <div className="flex shrink-0 items-center gap-0.5 pt-1 pr-0.5 ...">
    ...
  </div>
</div>

This keeps the full validation message readable for mouse, keyboard, and touch users, and avoids adding state/ref measurement just to reveal required content.

@hjlarry hjlarry marked this pull request as draft April 28, 2026 02:54
@hjlarry
Copy link
Copy Markdown
Contributor Author

hjlarry commented Apr 28, 2026

image ## Issue

Workflow checklist validation messages are rendered as single-line truncated text in the details popover. When a validation message is long, users cannot read the full message directly, which makes it harder to understand what needs to be fixed.

Fix

  • Allow checklist validation messages to wrap instead of truncating them.
  • Align checklist rows to the top so the indicator stays associated with the first line of the message.
  • Add top padding to the "Go to fix" action so it remains aligned with the first line when the message wraps.

@hjlarry hjlarry changed the title fix: show checklist message tooltip when truncated fix: show full checklist message tooltip instead of truncated Apr 28, 2026
@hjlarry hjlarry marked this pull request as ready for review April 28, 2026 03:18
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 28, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 28, 2026
@lyzno1 lyzno1 added this pull request to the merge queue Apr 28, 2026
Merged via the queue into langgenius:main with commit cbb4cc5 Apr 28, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

show checklist message tooltip when truncated

2 participants