Skip to content

fix: restore app nav create submenu interaction#35681

Merged
lyzno1 merged 3 commits into
langgenius:mainfrom
hjlarry:codex/myori-main-dev
Apr 29, 2026
Merged

fix: restore app nav create submenu interaction#35681
lyzno1 merged 3 commits into
langgenius:mainfrom
hjlarry:codex/myori-main-dev

Conversation

@hjlarry
Copy link
Copy Markdown
Contributor

@hjlarry hjlarry commented Apr 29, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #35680

Fix the app navigation "New App" submenu interaction.

The previous implementation nested a Headless UI Menu inside another MenuItems. With the current Headless UI behavior, clicking the nested MenuButton could close the parent menu before the submenu interaction completed, so the submenu appeared unresponsive.

This change replaces the nested menu with a locally controlled inline submenu inside the parent menu. It also removes the default focus outline from the parent menu panel.

Screenshots

img_v3_02117_ef306ba7-8df5-499c-add7-32985e6063eg

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@hjlarry hjlarry requested a review from iamjoel as a code owner April 29, 2026 06:32
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript Pull requests that update javascript code labels Apr 29, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Apr 29, 2026
lyzno1
lyzno1 previously approved these changes Apr 29, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 29, 2026
lyzno1
lyzno1 previously approved these changes Apr 29, 2026
@lyzno1 lyzno1 enabled auto-merge April 29, 2026 06:44
@lyzno1 lyzno1 added this pull request to the merge queue Apr 29, 2026
Merged via the queue into langgenius:main with commit ed7ea68 Apr 29, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

app nav create submenu not work

2 participants