refactor: replace Any with [T] syntax#35750
Merged
asukaminato0721 merged 2 commits intoApr 30, 2026
Merged
Conversation
aliworksx08
requested review from
Yeuoly,
crazywoola and
laipz8200
as code owners
dosubot
Bot
added
size:L
Contributor
Author
|
@asukaminato0721, could you review my PR, please? |
asukaminato0721
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34878
This PR addresses issue by replacing Any usage with Python 3.12+ [T] syntax and specific type annotations. The changes improve type safety and leverage modern Python typing features now that the project requires Python 3.12+.
Changes
Motivation: The project requires Python 3.12+ (requires-python = "~=3.12.0"), so we should leverage modern typing features to eliminate Any usage and improve code quality as recommended in AGENTS.md.
Test
This change requires a documentation update, included: Dify Document
I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
I've updated the documentation accordingly.
I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods