Skip to content

refactor(web): migrate legacy tooltip to infotip#35774

Merged
lyzno1 merged 11 commits into
mainfrom
codex/migrate-legacy-overlays
May 4, 2026
Merged

refactor(web): migrate legacy tooltip to infotip#35774
lyzno1 merged 11 commits into
mainfrom
codex/migrate-legacy-overlays

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 3, 2026

Summary

  • migrate low-risk legacy overlay usages to dify-ui Tooltip, DropdownMenu, and Infotip/Popover primitives
  • refactor checkbox-with-label layouts to avoid infotip hover layout shifts while preserving checkbox labeling semantics
  • migrate LLM node field and structured-output help overlays with semantic Tooltip vs Infotip usage
  • shrink the legacy overlay ESLint allowlist from 15 entries to 6

Review notes

  • Info-icon triggers that exist only to reveal help content use Infotip/Popover semantics.
  • Existing controls with their own primary action, such as badges or warning/status icons, keep Tooltip semantics.
  • Theme selector uses Base UI DropdownMenu radio items with explicit closeOnClick.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript Pull requests that update javascript code refactor labels May 3, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 3, 2026
@lyzno1 lyzno1 changed the title refactor(web): migrate low-risk legacy overlays refactor(web): migrate legacy tooltip to infotip May 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

❌ Patch coverage is 92.64706% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.67%. Comparing base (81090ef) to head (a0dafc4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rkflow/nodes/llm/components/config-prompt-item.tsx 0.00% 2 Missing ⚠️
...mponents/app/configuration/config-vision/index.tsx 0.00% 1 Missing ⚠️
...eate/step-two/components/indexing-mode-section.tsx 92.30% 1 Missing ⚠️
...ts/workflow/nodes/_base/components/option-card.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35774      +/-   ##
==========================================
- Coverage   85.67%   85.67%   -0.01%     
==========================================
  Files        4458     4458              
  Lines      209000   208999       -1     
  Branches    39044    39047       +3     
==========================================
- Hits       179059   179057       -2     
- Misses      26777    26780       +3     
+ Partials     3164     3162       -2     
Flag Coverage Δ
dify-ui 93.01% <ø> (ø)
web 86.45% <92.64%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 enabled auto-merge May 3, 2026 13:57
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 4, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 4, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 4, 2026
Merged via the queue into main with commit 1359c03 May 4, 2026
33 checks passed
@lyzno1 lyzno1 deleted the codex/migrate-legacy-overlays branch May 4, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer refactor size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants