Skip to content

refactor(web): migrate workflow node actions menu#35785

Merged
lyzno1 merged 1 commit into
mainfrom
codex/workflow-node-actions-menu
May 4, 2026
Merged

refactor(web): migrate workflow node actions menu#35785
lyzno1 merged 1 commit into
mainfrom
codex/workflow-node-actions-menu

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 4, 2026

Summary

  • move workflow node actions out of the legacy panel-operator implementation into node-actions-menu
  • split dropdown and context menu content so each overlay uses its own primitive
  • update node context menu positioning to use client coordinates with Base UI context menu anchoring

Tests

  • pnpm test app/components/workflow/node-actions-menu/tests/index.spec.tsx app/components/workflow/node-actions-menu/tests/details.spec.tsx app/components/workflow/tests/node-contextmenu.spec.tsx app/components/workflow/tests/workflow-edge-events.spec.tsx app/components/workflow/nodes/_base/components/tests/node-control.spec.tsx app/components/workflow/nodes/_base/components/workflow-panel/tests/index.spec.tsx app/components/workflow/store/tests/workflow-store.spec.ts app/components/workflow/hooks/tests/use-panel-interactions.spec.ts app/components/workflow/hooks/tests/use-selection-interactions.spec.ts app/components/workflow/hooks/tests/use-nodes-interactions.spec.ts

@lyzno1 lyzno1 requested review from iamjoel and zxhlyh as code owners May 4, 2026 12:52
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. refactor labels May 4, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 4, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.66%. Comparing base (81090ef) to head (c694aae).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...orkflow/node-actions-menu/context-menu-content.tsx 0.00% 25 Missing ⚠️
...w/node-actions-menu/use-node-actions-menu-model.ts 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35785      +/-   ##
==========================================
- Coverage   85.67%   85.66%   -0.01%     
==========================================
  Files        4458     4461       +3     
  Lines      209000   209037      +37     
  Branches    39044    39067      +23     
==========================================
+ Hits       179059   179073      +14     
- Misses      26777    26800      +23     
  Partials     3164     3164              
Flag Coverage Δ
dify-ui 93.01% <ø> (ø)
web 86.43% <77.77%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 enabled auto-merge May 4, 2026 12:59
@lyzno1 lyzno1 added this pull request to the merge queue May 4, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 4, 2026
Merged via the queue into main with commit 8f3e42e May 4, 2026
32 of 33 checks passed
@lyzno1 lyzno1 deleted the codex/workflow-node-actions-menu branch May 4, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants