Skip to content

fix(web): normalize dify-ui overlay control#35832

Merged
lyzno1 merged 6 commits into
mainfrom
codex/fix-dify-ui-overlay-control
May 6, 2026
Merged

fix(web): normalize dify-ui overlay control#35832
lyzno1 merged 6 commits into
mainfrom
codex/fix-dify-ui-overlay-control

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 6, 2026

Summary

  • Normalize touched dify-ui overlay call sites to controlled open / onOpenChange usage instead of gating overlay content with JSX conditionals.
  • Keep create subscription modal state controlled with isCreateModalOpen; move modal business state into DialogContent so Base UI owns content mount/unmount during close animations.
  • Remove per-call-site z-index overrides from @langgenius/dify-ui/* overlay call sites, including popupClassName="z-*", positionerProps.style.zIndex, and the variable reference wrapper zIndex escape hatch. Legacy PortalToFollowElem call sites are intentionally left untouched.
  • Update the create subscription modal mock to respect controlled open=false.

Docs checked

  • Base UI Dialog docs: controlled usage is open + onOpenChange; manual unmount / keepMounted / actionsRef is for JavaScript animation control.
  • web/docs/overlay-migration.md: new dify-ui overlays should not add per-call-site z-index overrides.
  • packages/dify-ui/AGENTS.md: overlay primitive semantics, z-index contract, and accessibility expectations.
  • Vercel React / Web Interface Guidelines: explicit conditional rendering, visible focus/accessibility, no unnecessary state effects.

Verification

  • pnpm type-check
  • pnpm lint:tss
  • pnpm test app/components/apps/__tests__/app-card.spec.tsx app/education-apply/__tests__/search-input.spec.tsx app/components/plugins/plugin-detail-panel/subscription-list/create/__tests__/common-modal.spec.tsx app/components/plugins/plugin-detail-panel/subscription-list/create/__tests__/index.spec.tsx
  • Targeted ESLint on changed files: 0 errors; remaining output is existing warnings.
  • Precise scan for dify-ui overlay z-index overrides: 0 matches.

@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. javascript Pull requests that update javascript code labels May 6, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.81%. Comparing base (03e227f) to head (3d2d645).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
web/app/components/apps/app-card.tsx 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #35832   +/-   ##
=======================================
  Coverage   85.81%   85.81%           
=======================================
  Files        4459     4459           
  Lines      208987   208994    +7     
  Branches    39063    39062    -1     
=======================================
+ Hits       179343   179351    +8     
+ Misses      26477    26476    -1     
  Partials     3167     3167           
Flag Coverage Δ
dify-ui 93.27% <ø> (ø)
web 86.76% <98.21%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 requested a review from WTW0313 as a code owner May 6, 2026 07:16
@lyzno1 lyzno1 requested a review from hyoban as a code owner May 6, 2026 07:18
@lyzno1 lyzno1 enabled auto-merge May 6, 2026 07:18
@lyzno1 lyzno1 added this pull request to the merge queue May 6, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 6, 2026
Merged via the queue into main with commit 8967ff3 May 6, 2026
33 checks passed
@lyzno1 lyzno1 deleted the codex/fix-dify-ui-overlay-control branch May 6, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants