fix(web): normalize dify-ui overlay control#35832
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35832 +/- ##
=======================================
Coverage 85.81% 85.81%
=======================================
Files 4459 4459
Lines 208987 208994 +7
Branches 39063 39062 -1
=======================================
+ Hits 179343 179351 +8
+ Misses 26477 26476 -1
Partials 3167 3167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hyoban
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
open/onOpenChangeusage instead of gating overlay content with JSX conditionals.isCreateModalOpen; move modal business state intoDialogContentso Base UI owns content mount/unmount during close animations.@langgenius/dify-ui/*overlay call sites, includingpopupClassName="z-*",positionerProps.style.zIndex, and the variable reference wrapperzIndexescape hatch. LegacyPortalToFollowElemcall sites are intentionally left untouched.open=false.Docs checked
open+onOpenChange; manual unmount /keepMounted/actionsRefis for JavaScript animation control.web/docs/overlay-migration.md: new dify-ui overlays should not add per-call-site z-index overrides.packages/dify-ui/AGENTS.md: overlay primitive semantics, z-index contract, and accessibility expectations.Verification
pnpm type-checkpnpm lint:tsspnpm test app/components/apps/__tests__/app-card.spec.tsx app/education-apply/__tests__/search-input.spec.tsx app/components/plugins/plugin-detail-panel/subscription-list/create/__tests__/common-modal.spec.tsx app/components/plugins/plugin-detail-panel/subscription-list/create/__tests__/index.spec.tsx