fix(web): explicitly resume AudioContext and play audio on first TTS load#35901
Merged
Merged
Conversation
…load AudioPlayer.playAudio() on first call went directly to loadAudio() without calling audio.play(), relying solely on autoplay=true. When audio is routed through AudioContext via createMediaElementSource, autoplay is unreliable and the AudioContext may be suspended, producing no sound despite a valid API response. Mirror the SSE path (playAudioWithAudio) by explicitly resuming the AudioContext and calling audio.play() before streaming begins. Fixes langgenius#35880
crazywoola
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AudioPlayer.playAudio() on first call went directly to loadAudio() without calling audio.play(), relying solely on autoplay=true. When audio is routed through AudioContext via createMediaElementSource, autoplay is unreliable and the AudioContext may be suspended, producing no sound despite a valid API response.
Mirror the SSE path (playAudioWithAudio) by explicitly resuming the AudioContext and calling audio.play() before streaming begins.
Fixes #35880
Important
Fixes #<issue number>.Summary
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods