Skip to content

refactor(web): converge overlay layering on dify-ui z-50#35976

Merged
lyzno1 merged 11 commits into
mainfrom
refactor/z-index
May 9, 2026
Merged

refactor(web): converge overlay layering on dify-ui z-50#35976
lyzno1 merged 11 commits into
mainfrom
refactor/z-index

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 9, 2026

Summary

  • converge dify-ui overlay primitives on the shared z-50 layer and keep toast at z-60
  • migrate remaining drawer-plus callers to @langgenius/dify-ui/drawer and remove drawer-plus
  • replace the migration guide with the current overlay best-practice guide
  • remove stale high z-index overlay assertions and keep nested drawer dismissal/backdrop behavior wired through Base UI

@github-actions github-actions Bot added the web This relates to changes on the web. label May 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 71.24183% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.82%. Comparing base (8581a68) to head (916b055).

Files with missing lines Patch % Lines
...nents/tools/edit-custom-collection-modal/index.tsx 60.00% 18 Missing ⚠️
...ents/tools/setting/build-in/config-credentials.tsx 42.85% 8 Missing ⚠️
...nts/app/annotation/edit-annotation-modal/index.tsx 76.19% 5 Missing ⚠️
...ents/app/annotation/add-annotation-modal/index.tsx 50.00% 4 Missing ⚠️
...nts/app/annotation/view-annotation-modal/index.tsx 73.33% 4 Missing ⚠️
...ts/tools/edit-custom-collection-modal/test-api.tsx 60.00% 4 Missing ⚠️
web/service/tools.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35976      +/-   ##
==========================================
- Coverage   85.82%   85.82%   -0.01%     
==========================================
  Files        4454     4453       -1     
  Lines      209796   209795       -1     
  Branches    39295    39294       -1     
==========================================
- Hits       180067   180047      -20     
- Misses      26514    26533      +19     
  Partials     3215     3215              
Flag Coverage Δ
dify-ui 94.40% <100.00%> (ø)
web 86.62% <71.05%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 marked this pull request as ready for review May 9, 2026 12:05
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. javascript Pull requests that update javascript code refactor labels May 9, 2026
@lyzno1 lyzno1 enabled auto-merge May 9, 2026 12:16
Copy link
Copy Markdown
Contributor

@CodingOnStar CodingOnStar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 9, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit 24ea21d May 9, 2026
32 of 33 checks passed
@lyzno1 lyzno1 deleted the refactor/z-index branch May 9, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer refactor size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants