fix(trace): LangSmith trace_id mismatch in chatflow workflow traces#35979
Merged
Conversation
In workflow_trace(), trace_id was set from trace_info.trace_id (external trace ID from X-Trace-Id header) before falling back to message_id. When an external trace_id is present and differs from message_id, LangSmith rejects the batch with HTTP 400 because trace_id must equal the first UUID in dotted_order (which is always the root run's run_id). Fix: derive trace_id from the root run's actual run_id — message_id for chatflows, workflow_run_id for pure workflows. The external trace_id is preserved in metadata for cross-system correlation. Fixes: langgenius#35972
dosubot
Bot
added
the
size:XS
Contributor
Pyrefly Type Coverage
|
fatelei
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In workflow_trace(), trace_id was set from trace_info.trace_id (external trace ID from X-Trace-Id header) before falling back to message_id. When an external trace_id is present and differs from message_id, LangSmith rejects the batch with HTTP 400 because trace_id must equal the first UUID in dotted_order (which is always the root run's run_id).
Fix: derive trace_id from the root run's actual run_id — message_id for chatflows, workflow_run_id for pure workflows. The external trace_id is preserved in metadata for cross-system correlation.
Fixes: #35972
Important
Fixes #<issue number>.Summary
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods