Skip to content

feat: allow disabling run time cred check#36031

Merged
wylswz merged 7 commits into
langgenius:mainfrom
wylswz:feat/allow-disabling-run-time-cred-check
May 14, 2026
Merged

feat: allow disabling run time cred check#36031
wylswz merged 7 commits into
langgenius:mainfrom
wylswz:feat/allow-disabling-run-time-cred-check

Conversation

@wylswz
Copy link
Copy Markdown
Contributor

@wylswz wylswz commented May 11, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Credential policy check at run-time introduces degradation on TTFE, so we provide an option to disabling it for latency critical users.

The validation is still performed while publishing the workflow.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels May 11, 2026
@wylswz wylswz changed the title Feat/allow disabling run time cred check feat: allow disabling run time cred check May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-05-13 12:34:15.651349885 +0000
+++ /tmp/pyrefly_pr.txt	2026-05-13 12:34:03.547259206 +0000
@@ -28,6 +28,8 @@
    --> core/app/task_pipeline/easy_ui_based_generate_task_pipeline.py:321:29
 ERROR Argument `list[Unknown]` is not assignable to parameter `value` with type `SQLCoreOperations[dict[str, Any]] | dict[str, Any]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
    --> core/app/task_pipeline/easy_ui_based_generate_task_pipeline.py:388:27
+ERROR Cannot find module `dify.api.configs` [missing-import]
+ --> core/helper/credential_utils.py:5:1
 ERROR No matching overload found for function `core.model_manager.ModelInstance.invoke_llm` called with arguments: (prompt_messages=list[UserPromptMessage], model_parameters=dict[str, int], stream=Literal[False]) [no-matching-overload]
    --> core/llm_generator/llm_generator.py:113:60
 ERROR No matching overload found for function `core.model_manager.ModelInstance.invoke_llm` called with arguments: (prompt_messages=list[UserPromptMessage], model_parameters=dict[str, float | int] | dict[str, object] | dict[Unknown, Unknown], stop=list[str] | list[Unknown], stream=Literal[False]) [no-matching-overload]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 0.00% 43.69% +43.69%
Strict coverage 0.00% 43.22% +43.22%
Typed symbols 0 22,031 +22,031
Untyped symbols 0 28,701 +28,701
Modules 0 2552 +2,552

@wylswz wylswz force-pushed the feat/allow-disabling-run-time-cred-check branch from 5d41afd to 2ffc786 Compare May 13, 2026 12:35
@wylswz
Copy link
Copy Markdown
Contributor Author

wylswz commented May 14, 2026

@dosubot review

@dosubot
Copy link
Copy Markdown

dosubot Bot commented May 14, 2026

I appreciate you tagging me, but I don't perform traditional code review (assessing PRs for bugs, design, style, performance, or security).

However, I can help in other ways:

  • Research the affected code areas or related documentation
  • Answer questions about how the credential check logic works today
  • Suggest documentation updates if this feature needs user-facing docs

Let me know if any of those would be useful!

To reply, just mention @dosu.


Share context across your team and agents. Try Dosu.

Leave Feedback Learn about dify with Dosu

Copy link
Copy Markdown
Contributor

@GareArc GareArc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 14, 2026
@wylswz wylswz enabled auto-merge May 14, 2026 07:11
@wylswz wylswz added this pull request to the merge queue May 14, 2026
Merged via the queue into langgenius:main with commit a9bcec0 May 14, 2026
27 checks passed
@wylswz wylswz deleted the feat/allow-disabling-run-time-cred-check branch May 14, 2026 07:21
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants