feat: allow disabling run time cred check#36031
Merged
wylswz merged 7 commits intoMay 14, 2026
Merged
Conversation
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-05-13 12:34:15.651349885 +0000
+++ /tmp/pyrefly_pr.txt 2026-05-13 12:34:03.547259206 +0000
@@ -28,6 +28,8 @@
--> core/app/task_pipeline/easy_ui_based_generate_task_pipeline.py:321:29
ERROR Argument `list[Unknown]` is not assignable to parameter `value` with type `SQLCoreOperations[dict[str, Any]] | dict[str, Any]` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
--> core/app/task_pipeline/easy_ui_based_generate_task_pipeline.py:388:27
+ERROR Cannot find module `dify.api.configs` [missing-import]
+ --> core/helper/credential_utils.py:5:1
ERROR No matching overload found for function `core.model_manager.ModelInstance.invoke_llm` called with arguments: (prompt_messages=list[UserPromptMessage], model_parameters=dict[str, int], stream=Literal[False]) [no-matching-overload]
--> core/llm_generator/llm_generator.py:113:60
ERROR No matching overload found for function `core.model_manager.ModelInstance.invoke_llm` called with arguments: (prompt_messages=list[UserPromptMessage], model_parameters=dict[str, float | int] | dict[str, object] | dict[Unknown, Unknown], stop=list[str] | list[Unknown], stream=Literal[False]) [no-matching-overload]
|
Contributor
Pyrefly Type Coverage
|
5d41afd to
2ffc786
Compare
Contributor
Author
|
@dosubot review |
|
I appreciate you tagging me, but I don't perform traditional code review (assessing PRs for bugs, design, style, performance, or security). However, I can help in other ways:
Let me know if any of those would be useful! To reply, just mention @dosu. Share context across your team and agents. Try Dosu. |
zhangtaodemama
added a commit
to zhangtaodemama/langgenius-dify-bfaadcb0c706
that referenced
this pull request
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Credential policy check at run-time introduces degradation on TTFE, so we provide an option to disabling it for latency critical users.
The validation is still performed while publishing the workflow.
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods