Skip to content

refactor: enhance modal layouts and scrolling behavior across components#36033

Merged
lyzno1 merged 1 commit into
mainfrom
refactor/dialog-height
May 11, 2026
Merged

refactor: enhance modal layouts and scrolling behavior across components#36033
lyzno1 merged 1 commit into
mainfrom
refactor/dialog-height

Conversation

@CodingOnStar
Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

  • Updated various modal components to improve layout and scrolling behavior, ensuring content is properly contained and scrollable.
  • Adjusted CSS classes for better responsiveness and visual consistency.
  • Added tests to verify scrolling functionality within the ConfigModal.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

- Updated various modal components to improve layout and scrolling behavior, ensuring content is properly contained and scrollable.
- Adjusted CSS classes for better responsiveness and visual consistency.
- Added tests to verify scrolling functionality within the ConfigModal.
@CodingOnStar CodingOnStar requested a review from lyzno1 May 11, 2026 06:10
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript Pull requests that update javascript code refactor labels May 11, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 11, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.82%. Comparing base (1aa6188) to head (369fbe4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #36033   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files        4453     4453           
  Lines      209954   209963    +9     
  Branches    39350    39353    +3     
=======================================
+ Hits       180190   180201   +11     
+ Misses      26551    26549    -2     
  Partials     3213     3213           
Flag Coverage Δ
dify-ui 94.40% <ø> (ø)
web 86.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 added this pull request to the merge queue May 11, 2026
Merged via the queue into main with commit 1082f48 May 11, 2026
33 checks passed
@lyzno1 lyzno1 deleted the refactor/dialog-height branch May 11, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer refactor size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants