Skip to content

fix: fixed relative#36078

Merged
CodingOnStar merged 2 commits into
mainfrom
fix/dialog-fixed-relative
May 12, 2026
Merged

fix: fixed relative#36078
CodingOnStar merged 2 commits into
mainfrom
fix/dialog-fixed-relative

Conversation

@CodingOnStar
Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

CodingOnStar added 2 commits May 12, 2026 18:32
…l-bundle and publish-as-knowledge-pipeline-modal components
…nt functionality

- Removed unnecessary 'relative' class from DialogContent in InstallBundle and PublishAsKnowledgePipelineModal components for cleaner styling.
- Enhanced Publisher component to manage the state and functionality for publishing as a knowledge pipeline, including modal handling and API integration.
- Updated tests to reflect changes in the Publisher component and ensure proper functionality of the publish-as modal.
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript Pull requests that update javascript code labels May 12, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 12, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 12, 2026
@CodingOnStar CodingOnStar enabled auto-merge May 12, 2026 11:00
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.88%. Comparing base (680ef07) to head (783cc0d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #36078   +/-   ##
=======================================
  Coverage   85.88%   85.88%           
=======================================
  Files        4456     4456           
  Lines      210900   210907    +7     
  Branches    39440    39442    +2     
=======================================
+ Hits       181125   181132    +7     
  Misses      26551    26551           
  Partials     3224     3224           
Flag Coverage Δ
dify-ui 94.40% <ø> (ø)
web 86.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodingOnStar CodingOnStar added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit a18d7f5 May 12, 2026
33 checks passed
@CodingOnStar CodingOnStar deleted the fix/dialog-fixed-relative branch May 12, 2026 11:12
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 12, 2026
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 12, 2026
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 12, 2026
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants