Skip to content

refactor: stabilize selector preview cards#36105

Merged
lyzno1 merged 5 commits into
mainfrom
style/model-selector
May 13, 2026
Merged

refactor: stabilize selector preview cards#36105
lyzno1 merged 5 commits into
mainfrom
style/model-selector

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 13, 2026

Summary

  • 3c58326960 moves model selector preview state to one shared detached PreviewCard so selection no longer drops the preview anchor.
  • b32cad8d17 gives the model selector popup the default settings width to remove the LLM panel horizontal overflow.
  • 1bb69a9d1f applies the same shared PreviewCard handle/payload model to block selector nodes, tools, triggers, and featured marketplace rows.

Tests

  • pnpm test app/components/workflow/block-selector
  • pnpm type-check
  • git diff --check

@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. javascript Pull requests that update javascript code refactor labels May 13, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 13, 2026
@lyzno1 lyzno1 enabled auto-merge May 13, 2026 06:09
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 70.70707% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.87%. Comparing base (d110112) to head (af3d52a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tting/model-provider-page/model-selector/popup.tsx 55.00% 9 Missing ⚠️
...omponents/workflow/block-selector/start-blocks.tsx 66.66% 5 Missing ⚠️
...ents/workflow/block-selector/featured-triggers.tsx 75.00% 3 Missing ⚠️
...w/block-selector/rag-tool-recommendations/list.tsx 0.00% 3 Missing ⚠️
...ts/workflow/block-selector/trigger-plugin/item.tsx 57.14% 3 Missing ⚠️
.../app/components/workflow/block-selector/blocks.tsx 81.81% 2 Missing ⚠️
...ponents/workflow/block-selector/featured-tools.tsx 80.00% 2 Missing ⚠️
...nents/workflow/block-selector/tool/action-item.tsx 75.00% 1 Missing ⚠️
...flow/block-selector/trigger-plugin/action-item.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36105      +/-   ##
==========================================
- Coverage   85.88%   85.87%   -0.01%     
==========================================
  Files        4456     4456              
  Lines      210920   210959      +39     
  Branches    39446    39449       +3     
==========================================
+ Hits       181144   181162      +18     
- Misses      26552    26573      +21     
  Partials     3224     3224              
Flag Coverage Δ
dify-ui 94.40% <ø> (ø)
web 86.60% <70.70%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 13, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 13, 2026
Merged via the queue into main with commit 03861bc May 13, 2026
32 of 33 checks passed
@lyzno1 lyzno1 deleted the style/model-selector branch May 13, 2026 06:23
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 13, 2026
BeautyyuYanli pushed a commit that referenced this pull request May 13, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer refactor size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants