fix: replace deprecated testcontainers log waits#36125
Merged
asukaminato0721 merged 1 commit intoMay 15, 2026
Merged
Conversation
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-05-13 14:58:17.769703506 +0000
+++ /tmp/pyrefly_pr.txt 2026-05-13 14:58:08.237657606 +0000
@@ -633,7 +633,7 @@
ERROR Argument `_SimpleJinja2Renderer` is not assignable to parameter `jinja2_template_renderer` with type `Jinja2TemplateRenderer` in function `graphon.nodes.template_transform.template_transform_node.TemplateTransformNode.__init__` [bad-argument-type]
--> tests/integration_tests/workflow/nodes/test_template_transform.py:94:34
ERROR `dict[str, str | None]` is not assignable to attribute `env` with type `dict[str, str]` [bad-assignment]
- --> tests/test_containers_integration_tests/conftest.py:204:39
+ --> tests/test_containers_integration_tests/conftest.py:203:39
ERROR Argument value `Literal[0]` violates Pydantic `ge` constraint `Literal[1]` for field `page` [bad-argument-type]
--> tests/test_containers_integration_tests/controllers/console/app/test_app_apis.py:663:51
ERROR Object of class `RequestError` has no attribute `response` [missing-attribute]
|
Contributor
Pyrefly Type Coverage
|
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces deprecated wait_for_logs calls with structured LogMessageWaitStrategy readiness checks attached via waiting_for(...) before each container's start().
Changes:
- Import
LogMessageWaitStrategyinstead ofwait_for_logs. - Add
_wait_for_log_messagehelper applying message + startup timeout. - Configure wait strategies on Postgres, Redis, Dify Sandbox, and Dify Plugin Daemon containers prior to start.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asukaminato0721
approved these changes
May 15, 2026
zhangtaodemama
added a commit
to zhangtaodemama/langgenius-dify-bfaadcb0c706
that referenced
this pull request
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #35893
This PR replaces deprecated
wait_for_logsusage in Testcontainers-based integration test setup with structuredLogMessageWaitStrategyreadiness checks.The readiness checks are now configured on each container before startup for PostgreSQL, Redis, Dify Sandbox, and Dify Plugin Daemon. This removes the
DeprecationWarningwhile preserving the same startup log checks and timeout behavior.From Codex
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods