Skip to content

fix: fix delete logs failed#36151

Merged
hjlarry merged 2 commits into
langgenius:mainfrom
fatelei:issue-36120
May 14, 2026
Merged

fix: fix delete logs failed#36151
hjlarry merged 2 commits into
langgenius:mainfrom
fatelei:issue-36120

Conversation

@fatelei
Copy link
Copy Markdown
Contributor

@fatelei fatelei commented May 14, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #36120

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 14, 2026
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels May 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 0.00% 43.70% +43.70%
Strict coverage 0.00% 43.22% +43.22%
Typed symbols 0 22,026 +22,026
Untyped symbols 0 28,691 +28,691
Modules 0 2551 +2,551

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-05-14 03:55:32.061524231 +0000
+++ /tmp/pyrefly_pr.txt	2026-05-14 03:55:18.330540967 +0000
@@ -5953,9 +5953,9 @@
 ERROR Argument `FakeRepo` is not assignable to parameter `workflow_run_repo` with type `APIWorkflowRunRepository | None` in function `services.retention.workflow_run.clear_free_plan_expired_workflow_run_logs.WorkflowRunCleanup.__init__` [bad-argument-type]
    --> tests/unit_tests/services/test_clear_free_plan_expired_workflow_run_logs.py:114:49
 ERROR Class member `FixedDateTime.now` overrides parent class `datetime` in an inconsistent manner [bad-override]
-   --> tests/unit_tests/services/test_clear_free_plan_tenant_expired_logs.py:385:13
+   --> tests/unit_tests/services/test_clear_free_plan_tenant_expired_logs.py:403:13
 ERROR Class member `FixedDateTime.now` overrides parent class `datetime` in an inconsistent manner [bad-override]
-   --> tests/unit_tests/services/test_clear_free_plan_tenant_expired_logs.py:460:13
+   --> tests/unit_tests/services/test_clear_free_plan_tenant_expired_logs.py:478:13
 ERROR Object of class `FromClause` has no attribute `create` [missing-attribute]
   --> tests/unit_tests/services/test_credit_pool_service.py:19:5
 ERROR Object of class `FromClause` has no attribute `insert` [missing-attribute]

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 14, 2026
@hjlarry hjlarry added this pull request to the merge queue May 14, 2026
Merged via the queue into langgenius:main with commit d9ccfcb May 14, 2026
27 checks passed
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete logs older than X days Error

2 participants