Skip to content

fix(api): gracefully handle credential fetch failures in rag pipeline#36165

Merged
linw1995 merged 3 commits into
mainfrom
fix/400-on-single-credential-refresh-error
May 14, 2026
Merged

fix(api): gracefully handle credential fetch failures in rag pipeline#36165
linw1995 merged 3 commits into
mainfrom
fix/400-on-single-credential-refresh-error

Conversation

@linw1995
Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 0.00% 43.68% +43.68%
Strict coverage 0.00% 43.21% +43.21%
Typed symbols 0 22,031 +22,031
Untyped symbols 0 28,715 +28,715
Modules 0 2552 +2,552

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.89%. Comparing base (a9bcec0) to head (d6021b8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rvices/rag_pipeline/rag_pipeline_manage_service.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #36165   +/-   ##
=======================================
  Coverage   85.89%   85.89%           
=======================================
  Files        4454     4454           
  Lines      210844   210867   +23     
  Branches    39450    39452    +2     
=======================================
+ Hits       181104   181125   +21     
- Misses      26516    26519    +3     
+ Partials     3224     3223    -1     
Flag Coverage Δ
api 85.34% <95.55%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@hjlarry hjlarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 14, 2026
@linw1995 linw1995 added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit e660d7a May 14, 2026
32 checks passed
@linw1995 linw1995 deleted the fix/400-on-single-credential-refresh-error branch May 14, 2026 08:36
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-linear lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants