Skip to content

fix: pipeline template render#36168

Merged
FFXN merged 40 commits into
mainfrom
fix/pipeline-template-render
May 14, 2026
Merged

fix: pipeline template render#36168
FFXN merged 40 commits into
mainfrom
fix/pipeline-template-render

Conversation

@FFXN
Copy link
Copy Markdown
Contributor

@FFXN FFXN commented May 14, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Due to multiple commits in sessionmaker, the transaction is closed early.
When creating a pipeline using a template, the DataSet ID is returned as empty, causing the render to fail.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

FFXN and others added 30 commits March 3, 2026 14:31
…m service including remote template service and database, return responding error message.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…m service including remote template service and database, return responding error message.
# Conflicts:
#	api/services/rag_pipeline/pipeline_template/remote/remote_retrieval.py
# Conflicts:
#	api/providers/vdb/vdb-weaviate/src/dify_vdb_weaviate/weaviate_vector.py
# Conflicts:
#	api/tests/unit_tests/controllers/service_api/dataset/test_hit_testing.py
…e image preview to fail on the chunks details page of the knowledge base.
…e image preview to fail on the chunks details page of the knowledge base.
… is generated for external preview or download only.
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 0.00% 43.68% +43.68%
Strict coverage 0.00% 43.21% +43.21%
Typed symbols 0 22,034 +22,034
Untyped symbols 0 28,717 +28,717
Modules 0 2552 +2,552

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.90%. Comparing base (d1d1903) to head (1a0c8f6).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36168      +/-   ##
==========================================
+ Coverage   85.89%   85.90%   +0.01%     
==========================================
  Files        4454     4456       +2     
  Lines      210783   210739      -44     
  Branches    39427    39404      -23     
==========================================
- Hits       181047   181035      -12     
+ Misses      26515    26482      -33     
- Partials     3221     3222       +1     
Flag Coverage Δ
api 85.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 14, 2026
@FFXN FFXN added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit 7210f85 May 14, 2026
32 checks passed
@FFXN FFXN deleted the fix/pipeline-template-render branch May 14, 2026 09:20
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants