Skip to content

feat(MessageLogModal): refactor modal structure and improve tab handling#36169

Merged
CodingOnStar merged 2 commits into
mainfrom
fix/log-modal
May 14, 2026
Merged

feat(MessageLogModal): refactor modal structure and improve tab handling#36169
CodingOnStar merged 2 commits into
mainfrom
fix/log-modal

Conversation

@CodingOnStar
Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

  • Replaced floating modal implementation with a Dialog component for better accessibility and styling.
  • Introduced a type guard for active tab validation, ensuring only valid tabs are set.
  • Updated modal rendering logic to handle fixed and dynamic widths more effectively.
  • Adjusted tests to reflect changes in modal behavior and structure.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

- Replaced floating modal implementation with a Dialog component for better accessibility and styling.
- Introduced a type guard for active tab validation, ensuring only valid tabs are set.
- Updated modal rendering logic to handle fixed and dynamic widths more effectively.
- Adjusted tests to reflect changes in modal behavior and structure.
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. javascript Pull requests that update javascript code refactor labels May 14, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.89%. Comparing base (a9bcec0) to head (fac2afc).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...eb/app/components/base/message-log-modal/index.tsx 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36169      +/-   ##
==========================================
- Coverage   85.89%   85.89%   -0.01%     
==========================================
  Files        4454     4454              
  Lines      210844   210847       +3     
  Branches    39450    39451       +1     
==========================================
  Hits       181104   181104              
- Misses      26516    26519       +3     
  Partials     3224     3224              
Flag Coverage Δ
dify-ui 94.40% <ø> (ø)
web 86.60% <70.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 14, 2026
@CodingOnStar CodingOnStar added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit ebcc120 May 14, 2026
32 of 33 checks passed
@CodingOnStar CodingOnStar deleted the fix/log-modal branch May 14, 2026 08:56
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer refactor size:M This PR changes 30-99 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants