feat: initialize user timezone and language from browser#36170
Merged
Conversation
Contributor
Pyrefly Type Coverage
|
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-05-15 02:58:21.561305169 +0000
+++ /tmp/pyrefly_pr.txt 2026-05-15 02:58:14.573228316 +0000
@@ -3,7 +3,7 @@
ERROR Object of class `App` has no attribute `access_mode` [missing-attribute]
--> controllers/console/app/app.py:583:13
ERROR Argument `str | None` is not assignable to parameter `language` with type `str` in function `services.account_service.AccountService.send_email_register_email` [bad-argument-type]
- --> controllers/console/auth/email_register.py:73:108
+ --> controllers/console/auth/email_register.py:83:108
ERROR Object of class `MissingRouter` has no attribute `get` [missing-attribute]
--> controllers/console/init_validate.py:31:2
ERROR Object of class `MissingRouter` has no attribute `post` [missing-attribute]
@@ -535,7 +535,7 @@
ERROR No matching overload found for function `redis.client.Redis.__init__` called with arguments: (host=int | str | Unknown, port=int | str | Unknown, password=int | str | Unknown | None, db=int, ssl=bool, ssl_ca_certs=str | None, ssl_cert_reqs=Any | None, ssl_certfile=Any | None, ssl_keyfile=Any | None, socket_timeout=Literal[5], socket_connect_timeout=Literal[5], health_check_interval=Literal[30]) [no-matching-overload]
--> schedule/queue_monitor_task.py:14:21
ERROR Object of class `Tenant` has no attribute `role` [missing-attribute]
- --> services/account_service.py:1169:13
+ --> services/account_service.py:1179:13
ERROR No matching overload found for function `flask.helpers.stream_with_context` called with arguments: (Generator[bytes]) [no-matching-overload]
--> services/audio_service.py:144:56
ERROR No matching overload found for function `flask.helpers.stream_with_context` called with arguments: (Generator[bytes]) [no-matching-overload]
@@ -611,9 +611,9 @@
ERROR Argument value `Literal[0]` violates Pydantic `ge` constraint `Literal[1]` for field `page` [bad-argument-type]
--> tests/test_containers_integration_tests/controllers/console/app/test_app_apis.py:700:51
ERROR Object of class `RequestError` has no attribute `response` [missing-attribute]
- --> tests/test_containers_integration_tests/controllers/console/auth/test_oauth.py:197:9
+ --> tests/test_containers_integration_tests/controllers/console/auth/test_oauth.py:245:9
ERROR Object of class `RequestError` has no attribute `response` [missing-attribute]
- --> tests/test_containers_integration_tests/controllers/console/auth/test_oauth.py:198:9
+ --> tests/test_containers_integration_tests/controllers/console/auth/test_oauth.py:246:9
ERROR `SimpleNamespace` is not assignable to attribute `mcp_ns` with type `Namespace` [bad-assignment]
--> tests/test_containers_integration_tests/controllers/mcp/test_mcp.py:27:21
ERROR Attribute `payload` of class `Namespace` is a read-only property and cannot be set [read-only]
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #36170 +/- ##
==========================================
- Coverage 85.94% 85.93% -0.02%
==========================================
Files 4454 4458 +4
Lines 210919 211150 +231
Branches 39428 39476 +48
==========================================
+ Hits 181280 181450 +170
- Misses 26436 26499 +63
+ Partials 3203 3201 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests