fix: allow tag rename without type payload#36182
Merged
Merged
Conversation
Contributor
Pyrefly Type Coverage
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36182 +/- ##
==========================================
- Coverage 85.93% 85.93% -0.01%
==========================================
Files 4454 4454
Lines 210842 210847 +5
Branches 39412 39414 +2
==========================================
- Hits 181189 181188 -1
- Misses 26453 26459 +6
Partials 3200 3200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e10c7bc to
f927f05
Compare
f927f05 to
5d77b2b
Compare
hjlarry
approved these changes
May 15, 2026
lyzno1
added a commit
that referenced
this pull request
May 15, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nameContext
This fixes a regression introduced by #34422. That refactor made
TagBasePayload.typerequired whilePATCH /tags/{tag_id}still reused the create payload, causing rename requests with{ name }to fail withtype Field required.Tests
uv run --project api pytest api/tests/unit_tests/controllers/console/tag/test_tags.py -qpnpm -C web test service/client.spec.tsuv run --project api python -m py_compile api/controllers/console/tag/tags.py api/controllers/service_api/dataset/dataset.py api/services/tag_service.py