Skip to content

refactor: enhance layout and scrolling behavior in various modals for improved user experience#36210

Merged
CodingOnStar merged 2 commits into
mainfrom
fix/dialog-visible
May 15, 2026
Merged

refactor: enhance layout and scrolling behavior in various modals for improved user experience#36210
CodingOnStar merged 2 commits into
mainfrom
fix/dialog-visible

Conversation

@CodingOnStar
Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

refactor: enhance layout and scrolling behavior in various modals for improved user experience

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@github-actions github-actions Bot added the web This relates to changes on the web. label May 15, 2026
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 15, 2026
@dosubot dosubot Bot added javascript Pull requests that update javascript code refactor lgtm This PR has been approved by a maintainer labels May 15, 2026
@CodingOnStar CodingOnStar enabled auto-merge May 15, 2026 07:11
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.94%. Comparing base (28153df) to head (39ef2d9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36210      +/-   ##
==========================================
- Coverage   85.94%   85.94%   -0.01%     
==========================================
  Files        4454     4454              
  Lines      210917   210911       -6     
  Branches    39427    39426       -1     
==========================================
- Hits       181272   181266       -6     
  Misses      26442    26442              
  Partials     3203     3203              
Flag Coverage Δ
dify-ui 94.40% <ø> (ø)
web 86.60% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodingOnStar CodingOnStar added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit b04a385 May 15, 2026
33 checks passed
@CodingOnStar CodingOnStar deleted the fix/dialog-visible branch May 15, 2026 07:24
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer refactor size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants