fix: fallback phoenix parent trace when parent tracing disabled#36290
Merged
Blackoutta merged 5 commits intoMay 18, 2026
Merged
Conversation
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-05-18 03:27:52.286187295 +0000
+++ /tmp/pyrefly_pr.txt 2026-05-18 03:27:44.229106557 +0000
@@ -72,6 +72,10 @@
--> extensions/storage/huawei_obs_storage.py:31:20
ERROR Argument `Module[Crypto.Hash.SHA1] | Unknown` is not assignable to parameter with type `Hash | HashModule` [bad-argument-type]
--> libs/gmpy2_pkcs10aep_cipher.py:73:49
+ERROR `opentelemetry.trace.Tracer` is not assignable to attribute `tracer` with type `opentelemetry.sdk.trace.Tracer` [bad-assignment]
+ --> providers/trace/trace-arize-phoenix/tests/unit_tests/arize_phoenix_trace/test_arize_phoenix_trace.py:1722:29
+ERROR Object of class `NoneType` has no attribute `trace_id` [missing-attribute]
+ --> providers/trace/trace-arize-phoenix/tests/unit_tests/arize_phoenix_trace/test_arize_phoenix_trace.py:1744:12
ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `dify_vdb_alibabacloud_mysql.alibabacloud_mysql_vector.AlibabaCloudMySQLVectorFactory.init_vector` [bad-argument-type]
--> providers/vdb/vdb-alibabacloud-mysql/tests/unit_tests/test_alibabacloud_mysql_factory.py:42:38
ERROR Argument `SimpleNamespace` is not assignable to parameter `dataset` with type `Dataset` in function `dify_vdb_alibabacloud_mysql.alibabacloud_mysql_vector.AlibabaCloudMySQLVectorFactory.init_vector` [bad-argument-type]
|
Contributor
Pyrefly Type Coverage
|
dcc2126 to
f45a58a
Compare
crazywoola
approved these changes
May 18, 2026
zhangtaodemama
added a commit
to zhangtaodemama/langgenius-dify-bfaadcb0c706
that referenced
this pull request
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Fixes #36289
This PR ports the Phoenix parent trace fallback behavior described in the source-branch spec
docs/superpowers/specs/2026-05-16-phoenix-parent-trace-fallback-design.mdfrom commitf224813e63d33f582a79f5c76e573738620f28b0into the current trace provider package layout.Nested workflow traces can include a
parent_trace_contextso Phoenix/Arize can attach the child workflow under the parent workflow's tool node span. When the parent workflow has Phoenix/Arize tracing disabled, that parent span carrier can never be published to Redis. The current provider treats the missing carrier as pending and retries until the retry budget is exhausted.The change keeps normal parent-carrier behavior for traceable parents, but falls back to a synthetic root keyed by
parent_workflow_run_idwhen the parent app cannot publish Phoenix/Arize carrier data. Missing carriers remain retryable when the parent app can publish context, unknown parent workflow runs remain retryable, and malformed Redis carriers still fail as hard errors.It also starts Phoenix synthetic root spans with an empty OpenTelemetry
Context()so an ambient unsampled parent span cannot suppress or parent the synthetic root.Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint godsValidation run: