refactor: migrate checkbox to dify-ui#36295
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #36295 +/- ##
==========================================
- Coverage 85.94% 85.93% -0.01%
==========================================
Files 4458 4456 -2
Lines 211298 211260 -38
Branches 39503 39487 -16
==========================================
- Hits 181593 181556 -37
+ Misses 26501 26500 -1
Partials 3204 3204
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hyoban
approved these changes
May 18, 2026
zhangtaodemama
added a commit
to zhangtaodemama/langgenius-dify-bfaadcb0c706
that referenced
this pull request
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webto@langgenius/dify-ui/checkboxweb/app/components/base/checkboximplementation, tests, and stories to consolidate on the new primitivechecked,onCheckedChange, andindeterminateonCheck,ariaLabel, andariaLabelledBy, replacing them with native label composition patterns oraria-labelonly where necessaryTesting
pnpm --dir packages/dify-ui test src/checkbox src/checkbox-grouppnpm --dir web type-checkpnpm --dir web test ...covering representative migration scenarios including dataset, plugin, form, annotation, and install flow related cases