fix(api): close base64 file lookup sessions#36308
Merged
asukaminato0721 merged 2 commits intoMay 18, 2026
Merged
Conversation
dosubot
Bot
added
the
size:S
Contributor
Pyrefly Type Coverage
|
This was referenced May 18, 2026
asukaminato0721
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #32454 (comment).
Close the private SQLAlchemy sessions created by
AttachmentService.get_file_base64()andFileService.get_file_base64().Both methods return a plain base64 string, not ORM objects or session-owned state. The caller never receives the session and cannot manage its lifetime, so the method should release the session after reading the needed
UploadFile.key.Why
Leaving these private sessions open can leave idle transactions around, consume DB resources, and block cleanup or DDL that needs stronger table locks.
This keeps the observable behavior the same: read the upload file row, copy the storage key, load bytes from storage, and return the base64-encoded string.
Validation
uv run --project api ruff check api/services/attachment_service.py api/services/file_service.pyuv run --project api python -m compileall -q api/services/attachment_service.py api/services/file_service.py