Skip to content

ci: ensure pnpm is available in setup-web action#36315

Merged
asukaminato0721 merged 1 commit into
mainfrom
codex/setup-web-corepack-pnpm
May 18, 2026
Merged

ci: ensure pnpm is available in setup-web action#36315
asukaminato0721 merged 1 commit into
mainfrom
codex/setup-web-corepack-pnpm

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 18, 2026

Summary

  • add setup-web action metadata description
  • install pnpm with the official pnpm/action-setup action before Vite+ setup
  • let pnpm/action-setup read the repository packageManager field and avoid a duplicate install

close #36317

Verification

  • ruby -e 'require "yaml"; YAML.load_file(".github/actions/setup-web/action.yml"); puts "yaml ok"'
  • go run github.com/rhysd/actionlint/cmd/actionlint@latest -ignore 'label ".*" is unknown'
  • git diff --check
  • pnpm --version

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. javascript Pull requests that update javascript code labels May 18, 2026
@lyzno1 lyzno1 force-pushed the codex/setup-web-corepack-pnpm branch from 872d0e1 to 935cf5f Compare May 18, 2026 06:45
@lyzno1 lyzno1 force-pushed the codex/setup-web-corepack-pnpm branch from 935cf5f to 5d7582d Compare May 18, 2026 06:47
@asukaminato0721 asukaminato0721 enabled auto-merge May 18, 2026 06:48
@asukaminato0721 asukaminato0721 requested a review from hyoban May 18, 2026 06:49
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.93%. Comparing base (28818f2) to head (5d7582d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #36315   +/-   ##
=======================================
  Coverage   85.93%   85.93%           
=======================================
  Files        4456     4456           
  Lines      211260   211260           
  Branches    39487    39487           
=======================================
  Hits       181556   181556           
  Misses      26500    26500           
  Partials     3204     3204           
Flag Coverage Δ
dify-ui 94.59% <ø> (ø)
web 86.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asukaminato0721 asukaminato0721 added this pull request to the merge queue May 18, 2026
Merged via the queue into main with commit 9697603 May 18, 2026
36 checks passed
@asukaminato0721 asukaminato0721 deleted the codex/setup-web-corepack-pnpm branch May 18, 2026 07:03
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

autofix.ci fails generating frontend contracts because pnpm is unavailable

3 participants