Skip to content

fix: improve API extension dialog controls#36323

Merged
lyzno1 merged 4 commits into
mainfrom
codex/fix-api-extension-dialog-controls
May 18, 2026
Merged

fix: improve API extension dialog controls#36323
lyzno1 merged 4 commits into
mainfrom
codex/fix-api-extension-dialog-controls

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 18, 2026

Summary

  • make the API-based extension modal fully controlled via open/onOpenChange
  • add DialogTitle/DialogCloseButton and disable outside-click dismissal
  • force-render the delete alert dialog backdrop and clean up touched legacy styling/icons

Tests

  • pnpm -C web test app/components/header/account-setting/api-based-extension-page/tests
  • pnpm --dir web type-check

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. javascript Pull requests that update javascript code labels May 18, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.94%. Comparing base (730a0be) to head (1de3116).

Files with missing lines Patch % Lines
...account-setting/api-based-extension-page/index.tsx 85.71% 2 Missing ⚠️
...ount-setting/api-based-extension-page/selector.tsx 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36323      +/-   ##
==========================================
- Coverage   85.94%   85.94%   -0.01%     
==========================================
  Files        4454     4455       +1     
  Lines      211360   211095     -265     
  Branches    39501    39440      -61     
==========================================
- Hits       181653   181420     -233     
+ Misses      26499    26480      -19     
+ Partials     3208     3195      -13     
Flag Coverage Δ
dify-ui 94.59% <ø> (ø)
web 86.55% <92.59%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 18, 2026
…on-dialog-controls

# Conflicts:
#	web/app/components/header/account-setting/api-based-extension-page/__tests__/index.spec.tsx
#	web/app/components/header/account-setting/api-based-extension-page/__tests__/item.spec.tsx
#	web/app/components/header/account-setting/api-based-extension-page/__tests__/modal.spec.tsx
#	web/app/components/header/account-setting/api-based-extension-page/__tests__/selector.spec.tsx
#	web/app/components/header/account-setting/api-based-extension-page/item.tsx
#	web/app/components/header/account-setting/api-based-extension-page/modal.tsx
#	web/app/components/header/account-setting/api-based-extension-page/selector.tsx
#	web/context/modal-context-provider.tsx
#	web/context/modal-context.ts
@lyzno1 lyzno1 enabled auto-merge May 18, 2026 07:57
@lyzno1 lyzno1 added this pull request to the merge queue May 18, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 18, 2026
Merged via the queue into main with commit 06ea0f7 May 18, 2026
33 checks passed
@lyzno1 lyzno1 deleted the codex/fix-api-extension-dialog-controls branch May 18, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants