Skip to content

fix: can not create empty knowledge#36336

Merged
laipz8200 merged 1 commit into
mainfrom
fix/can-not-create-knowledge-main
May 18, 2026
Merged

fix: can not create empty knowledge#36336
laipz8200 merged 1 commit into
mainfrom
fix/can-not-create-knowledge-main

Conversation

@laipz8200
Copy link
Copy Markdown
Member

(cherry picked from commit f1ba9cf)

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

(cherry picked from commit f1ba9cf)
@laipz8200 laipz8200 requested review from WTW0313 and iamjoel as code owners May 18, 2026 09:33
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. javascript Pull requests that update javascript code labels May 18, 2026
@laipz8200 laipz8200 added this to the 1.14.2 milestone May 18, 2026
@laipz8200 laipz8200 enabled auto-merge May 18, 2026 09:33
@github-actions github-actions Bot added the web This relates to changes on the web. label May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.94%. Comparing base (f4c02e4) to head (fc9e5aa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36336      +/-   ##
==========================================
- Coverage   85.94%   85.94%   -0.01%     
==========================================
  Files        4454     4454              
  Lines      211503   211503              
  Branches    39515    39515              
==========================================
- Hits       181782   181779       -3     
- Misses      26509    26512       +3     
  Partials     3212     3212              
Flag Coverage Δ
dify-ui 94.59% <ø> (ø)
web 86.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@CodingOnStar CodingOnStar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laipz8200 laipz8200 added this pull request to the merge queue May 18, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 18, 2026
Merged via the queue into main with commit 5468c4e May 18, 2026
33 checks passed
@laipz8200 laipz8200 deleted the fix/can-not-create-knowledge-main branch May 18, 2026 09:48
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants